3824

pending completion

Build # 3824

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #3459 from roseline124/3445-paste-2-images

fix cliboard paste image two times bug

Run Details

1058 of 1901 branches covered (55.65%)

1 of 1 new or added line in 1 file covered. (100.0%)

4677 of 5974 relevant lines covered (78.29%)

639.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

31.58

/src/js/base/module/Clipboard.js

import lists from '../core/lists';

export default class Clipboard {
  constructor(context) {
    this.context = context;
    this.$editable = context.layoutInfo.editable;
  }

  initialize() {
    this.$editable.on('paste', this.pasteByEvent.bind(this));
  }

  /**
   * paste by clipboard event
   *
   * @param {Event} event
   */
  pasteByEvent(event) {
    const clipboardData = event.originalEvent.clipboardData;
    if (clipboardData && clipboardData.items && clipboardData.items.length) {
      const item = clipboardData.items.length > 1 ? clipboardData.items[1] : lists.head(clipboardData.items);
      if (item.kind === 'file' && item.type.indexOf('image/') !== -1) {
        // paste img file
        this.context.invoke('editor.insertImagesOrCallback', [item.getAsFile()]);
        event.preventDefault();

        this.context.invoke('editor.afterCommand');
      } else if (item.kind === 'string') {
        // paste text with maxTextLength check
        if (this.context.invoke('editor.isLimited', clipboardData.getData('Text').length)) {
          event.preventDefault();
        } else {
          this.context.invoke('editor.afterCommand');
        }
      }
    }
  }
}

1	import lists from '../core/lists';	6✔
2		6✔
3	export default class Clipboard {	6✔
4	constructor(context) {	6✔
5	this.context = context;	12✔
6	this.$editable = context.layoutInfo.editable;	627✔
7	}	627✔
8
9	initialize() {	6✔
10	this.$editable.on('paste', this.pasteByEvent.bind(this));	627✔
11	}
12
13	/**
14	* paste by clipboard event
15	*
16	* @param {Event} event
17	*/	6✔
18	pasteByEvent(event) {	×
19	const clipboardData = event.originalEvent.clipboardData;	×
20	if (clipboardData && clipboardData.items && clipboardData.items.length) {	×
21	const item = clipboardData.items.length > 1 ? clipboardData.items[1] : lists.head(clipboardData.items);	×
22	if (item.kind === 'file' && item.type.indexOf('image/') !== -1) {
23	// paste img file	×
24	this.context.invoke('editor.insertImagesOrCallback', [item.getAsFile()]);	×
25	event.preventDefault();	×
26
27	this.context.invoke('editor.afterCommand');	×
28	} else if (item.kind === 'string') {
29	// paste text with maxTextLength check	×
30	if (this.context.invoke('editor.isLimited', clipboardData.getData('Text').length)) {	×
31	event.preventDefault();
32	} else {
33	this.context.invoke('editor.afterCommand');	×
34	}
35	}
36	}
37	}
38	}	6✔

summernote / summernote / 3824

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous