google / upb / 104

pending completion

Build # 104

Build Type

Pull #27

travis-ci

Committed by

haberman

Commit Message

Ported upb to C89, for greater portability.

A large part of this change contains surface-level
porting, like moving variable declarations to the
top of the block.

However there are a few more substantial things too:

- moved internal-only struct definitions to a separate
  file (structdefs.int.h), for greater encapsulation
  and ABI compatibility.

- removed the UPB_UPCAST macro, since it requires access
  to the internal-only struct definitions.  Replaced uses
  with calls to inline, type-safe casting functions.

- removed the UPB_DEFINE_CLASS/UPB_DEFINE_STRUCT macros.
  Class and struct definitions are now more explicit -- you
  get to see the actual class/struct keywords in the source.
  The casting convenience functions have been moved into
  UPB_DECLARE_DERIVED_TYPE() and UPB_DECLARE_DERIVED_TYPE2().

- the new way that we duplicate base methods in derived types
  is also more convenient and requires less duplication.
  It is also less greppable, but hopefully that is not
  too big a problem.

Compiler flags (-std=c89 -pedantic) should help to rigorously
enforce that the code is free of C99-isms.

A few functions are not available in C89 (strtoll).  There
are temporary, hacky solutions in place.

Pull Request Pull Request #27: Ported upb to C89, for greater portability.

Run Details

564 of 564 new or added lines in 31 files covered. (100.0%)

5290 of 6808 relevant lines covered (77.7%)

282760.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/upb/pb/compile_decoder.c

Build SHA Not Found

The commit SHA "74fd9d9406308560ee99a69b3f71daf2542275f5" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

google / upb / 104

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous