zendframework / zend-mail / 21

pending completion

Build # 21

Build Type

Pull #7

travis-ci

Committed by

echampet

Commit Message

Protocol\Smtp->data(): be more memory friendly (stream version)

With huge mails (50M, 660000 lines), i'm hitting memory_limit, so i've done some tests
looking at peak memory usage and average time(100 runs)
- str_replace("\r","") + explode("\n") 250M/0,27s (what we use now)
- preg_split("\r?\n") 200M/1,5s (too slow)
- strtok("\n") + rtrim("\r") 100M/0,27s (convert multiple \n\n\n in 1 -> ko)
- strpos("\n") + substr() 50M/0,35s
- fwrite(php://temp) + stream_get_line 50M/0,29s

The only problem with this version is the dependency on "php://temp"
(not sure if it's enable on all systems, fopen/fwrite can fail)

All tests were run with 'php -d"memory_limit=256M" -d"opcache.enable_cli=1"'

Before this patch, we were removing \r, now we're keeping them,
in any case \r should be encoded

Signed-off-by: Etienne CHAMPETIER <etienne.champetier@fiducial.net>

Pull Request Pull Request #7: Protocol\Smtp->data(): be more memory friendly (stream version)

Run Details

10 of 10 new or added lines in 1 file covered. (100.0%)

1533 of 3787 relevant lines covered (40.48%)

9.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.15

/src/Protocol/Smtp.php

Build SHA Not Found

The commit SHA "10a54ea9ef844969cba3ca1683d87579f954e994" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

zendframework / zend-mail / 21

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous