OCA / OpenUpgrade / 5860

5860

Pull #2080

travis-ci

web-flow 
[IMP] stock: Faster stock.move migration

This patch solves a bug and bunch of bottlenecks that were slowing down the execution of `move_stock_qty()`. The summary of changes is:

1. Inside `quants_unreserve()` I replaced a generator call for the much faster `.ids`. I know the usual thing is to not touch Odoo code, but this change doesn't affect logic but just performance.
2. Use sets instead of tuples for the `in` operator, always faster.
3. Avoid a bug in `_move_assign()` and `_move_done()` where the same outer variable name was being reused inside a loop, changing the result in unclean ways.
4. Index some fields that will be searched *a lot*.
5. Disable automatic field prefetching. Migrated models have lots of computed and relational fields that end up consuming more time than doing 1 query per field when needed.
6. Prefetch needed fields of as many records as possible before running the code, to avoid the previous point affecting the process negatively.
7. Add more logging so you can know the progress. This can be a big logging black hole otherwise.

Before this patch, it was processing about 3 moves/s in my server. After, it took about 10 mins prefetching things, but then it processed an average of 12 moves/s with peaks of more than 30 moves/s. That's 4x faster!

@Tecnativa TT18838
Pull Request #2080: [IMP] stock: Faster stock.move migration

35 of 35 new or added lines in 1 file covered. (100.0%)

1215 of 1358 relevant lines covered (89.47%)

0.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.31
/addons/stock/migrations/8.0.1.1/post-migration.py


Build SHA Not Found

The commit SHA "69ea3d3ce4ff2fa13572a521f3326fec05897ed1" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.