stanford-oval / thingpedia-api / 217

pending completion

Build # 217

Build Type

Pull #42

travis-ci

Committed by

web-flow

Commit Message

Rename DeviceFactoryUtils to DeviceConfigUtils

As suggested in review

Pull Request Pull Request #42: Import utilities to create device factories from almond-cloud

Run Details

495 of 646 branches covered (76.63%)

Branch coverage included in aggregate %.

45 of 55 new or added lines in 2 files covered. (81.82%)

43 existing lines in 11 files now uncovered.

1203 of 1380 relevant lines covered (87.17%)

23.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.02

/lib/device_factory_utils.js

1	// -- mode: js; indent-tabs-mode: nil; js-basic-offset: 4 --
2	//
3	// This file is part of Thingpedia
4	//
5	// Copyright 2018 The Board of Trustees of the Leland Stanford Junior University
6	//
7	// Author: Giovanni Campagna <gcampagn@cs.stanford.edu>
8	//
9	// See COPYING for details
10	"use strict";
11
12	function clean(name) {
13	if (/^[vwgp]_/.test(name))	4!
NEW 14	name = name.substr(2);	×
15	return name.replace(/_/g, ' ').replace(/([^A-Z ])([A-Z])/g, '$1 $2').toLowerCase();	4✔
16	}
17
18	function entityTypeToHTMLType(type) {
19	switch (type) {	2!
20	case 'tt:password':
NEW 21	return 'password';	×
22	case 'tt:url':
23	return 'url';	2✔
24	case 'tt:phone_number':
NEW 25	return 'tel';	×
26	case 'tt:email_address':
NEW 27	return 'email';	×
28	default:
NEW 29	return 'text';	×
30	}
31	}
32
33	function getInputParam(config, name) {
34	for (let inParam of config.in_params) {	12✔
35	if (inParam.name === name)	10✔
36	return inParam.value.toJS();	8✔
37	}
38	return undefined;	4✔
39	}
40
41	function makeDeviceFactory(classDef, device) {
42	if (classDef.is_abstract)	20✔
43	return null;	2✔
44
45	const config = classDef.config;	18✔
46
47	function toFields(argMap) {
48	if (!argMap)	6✔
49	return [];	2✔
50	return Object.keys(argMap).map((k) => {	4✔
51	const type = argMap[k];	4✔
52	let htmlType;
53	if (type.isEntity)	4✔
54	htmlType = entityTypeToHTMLType(type.type);	2✔
55	else if (type.isNumber \|\| type.isMeasure)	2!
NEW 56	htmlType = 'number';	×
57	else if (type.isBoolean)	2!
NEW 58	htmlType = 'checkbox';	×
59	else
60	htmlType = 'text';	2✔
61	return { name: k, label: clean(k), type: htmlType };	4✔
62	});
63	}
64
65	switch (config.module) {	18!
66	case 'org.thingpedia.config.builtin':
67	return null;	2✔
68
69	case 'org.thingpedia.config.discovery.bluetooth':
70	return {	2✔
71	type: 'discovery',
72	category: device.category,
73	kind: classDef.kind,
74	text: device.name,
75	discoveryType: 'bluetooth'
76	};
77	case 'org.thingpedia.config.discovery.upnp':
78	return {	2✔
79	type: 'discovery',
80	category: device.category,
81	kind: classDef.kind,
82	text: device.name,
83	discoveryType: 'upnp'
84	};
85
86	case 'org.thingpedia.config.interactive':
NEW 87	return {	×
88	type: 'interactive',
89	category: device.category,
90	kind: classDef.kind,
91	text: device.name
92	};
93
94	case 'org.thingpedia.config.none':
95	return {	2✔
96	type: 'none',
97	category: device.category,
98	kind: classDef.kind,
99	text: device.name
100	};
101
102	case 'org.thingpedia.config.oauth2':
103	case 'org.thingpedia.config.custom_oauth':
104	return {	4✔
105	type: 'oauth2',
106	category: device.category,
107	kind: classDef.kind,
108	text: device.name
109	};
110
111	case 'org.thingpedia.config.form':
112	return {	2✔
113	type: 'form',
114	category: device.category,
115	kind: classDef.kind,
116	text: device.name,
117	fields: toFields(getInputParam(config, 'params'))
118	};
119
120	case 'org.thingpedia.config.basic_auth':
121	return {	4✔
122	type: 'form',
123	category: device.category,
124	kind: classDef.kind,
125	text: device.name,
126	fields: [
127	{ name: 'username', label: 'Username', type: 'text' },
128	{ name: 'password', label: 'Password', type: 'password' }
129	].concat(toFields(getInputParam(config, 'extra_params')))
130	};
131
132	default:
NEW 133	throw new Error(`Unrecognized config mixin ${config.module}`);	×
134	}
135	}
136
137	function getDiscoveryServices(classDef) {
138	if (classDef.is_abstract)	8✔
139	return [];	2✔
140
141	const config = classDef.config;	6✔
142	switch (config.module) {	6✔
143	case 'org.thingpedia.config.discovery.bluetooth': {
144	const uuids = getInputParam(config, 'uuids');	2✔
145	const deviceClass = getInputParam(config, 'device_class');	2✔
146
147	const services = uuids.map((u) => {	2✔
148	return {	2✔
149	discovery_type: 'bluetooth',
150	service: 'uuid-' + u.toLowerCase()
151	};
152	});
153	if (deviceClass) {	2!
NEW 154	services.push({	×
155	discovery_type: 'bluetooth',
156	service: 'class-' + deviceClass
157	});
158	}
159	return services;	2✔
160	}
161	case 'org.thingpedia.config.discovery.upnp':
162	return getInputParam(config, 'search_target').map((st) => {	2✔
163	return {	2✔
164	discovery_type: 'upnp',
165	service: st.toLowerCase().replace(/^urn:/, '').replace(/:/g, '-')
166	};
167	});
168	default:
169	return [];	2✔
170	}
171	}
172
173	module.exports = {	2✔
174	makeDeviceFactory,
175	getDiscoveryServices
176	};

stanford-oval / thingpedia-api / 217

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous