690f08b6-1f66-4c4e-80a0-4c22096ef837

Build Type

circle-ci

Committed by mbklein

Commit Message

Make SheetsToWorks kick off file set pipelines; Fix up audit trail and tests

Run Details

4 of 11 branches covered (36.36%)

Branch coverage included in aggregate %.

117 of 158 new or added lines in 21 files covered. (74.05%)

105 existing lines in 10 files now uncovered.

502 of 615 relevant lines covered (81.63%)

12.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

23.08

/lib/meadow/data/audit_entries.ex

1	defmodule Meadow.Data.AuditEntries do
2	@moduledoc """
3	The AuditEntries context.
4	"""
5
6	import Ecto.Query, warn: false
7	alias Meadow.Data.AuditEntries.AuditEntry
8	alias Meadow.Repo
9
NEW 10	def latest_outcome_for(object_id), do: get_latest_entry_for(object_id).outcome	×
NEW 11	def error?(object_id), do: latest_outcome_for(object_id) == "error"	×
NEW 12	def ok?(object_id), do: latest_outcome_for(object_id) == "ok"	×
13
14	def get_latest_entry_for(object_id) do
NEW 15	from(	×
16	a in entries_for(object_id),
17	limit: 1
18	)
NEW 19	\|> Repo.one()	×
20	end
21
22	def get_entries_for(object_id) do
23	entries_for(object_id)
NEW 24	\|> Repo.all()	×
25	end
26
NEW 27	def add_entry(object_id, action, outcome, notes \\ nil),	×
NEW 28	do: Repo.insert(make_changeset(object_id, action, outcome, notes))	×
29
30	def add_entry!(object_id, action, outcome, notes \\ nil),	9✔
31	do: Repo.insert!(make_changeset(object_id, action, outcome, notes))	10✔
32
33	defp entries_for(object_id) do
NEW 34	from(a in AuditEntry,	×
35	where: a.object_id == ^object_id,
36	order_by: [desc: :updated_at]
37	)
38	end
39
40	defp make_changeset(object_id, action, outcome, notes) when is_nil(notes) or is_binary(notes) do
41	%AuditEntry{}
42	\|> AuditEntry.changeset(%{	10✔
43	object_id: object_id,
44	action: action,
45	outcome: outcome,
46	notes: notes
47	})
48	end
49
50	defp make_changeset(object_id, action, outcome, notes),
NEW 51	do: make_changeset(object_id, action, outcome, inspect(notes))	×
52	end