4240

Build # 4240

Build Type

push

buildkite

Committed by GitHub

Commit Message

Clean up some code in the retry logic (#6017)

Run Details

359 of 12902 branches covered (2.78%)

Branch coverage included in aggregate %.

3 of 7 new or added lines in 1 file covered. (42.86%)

16606 existing lines in 282 files now uncovered.

8767 of 38840 relevant lines covered (22.57%)

0.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.14

/synapse/push/action_generator.py

# -*- coding: utf-8 -*-
# Copyright 2015 OpenMarket Ltd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import logging

from twisted.internet import defer

from synapse.util.metrics import Measure

from .bulk_push_rule_evaluator import BulkPushRuleEvaluator

logger = logging.getLogger(__name__)


class ActionGenerator(object):
    def __init__(self, hs):
        self.hs = hs
        self.clock = hs.get_clock()
        self.store = hs.get_datastore()
        self.bulk_evaluator = BulkPushRuleEvaluator(hs)
        # really we want to get all user ids and all profile tags too,
        # since we want the actions for each profile tag for every user and
        # also actions for a client with no profile tag for each user.
        # Currently the event stream doesn't support profile tags on an
        # event stream, so we just run the rules for a client with no profile
        # tag (ie. we just need all the users).

    @defer.inlineCallbacks
    def handle_push_actions_for_event(self, event, context):
        with Measure(self.clock, "action_for_event_by_user"):
            yield self.bulk_evaluator.action_for_event_by_user(event, context)

1	# -- coding: utf-8 --
2	# Copyright 2015 OpenMarket Ltd
3	#
4	# Licensed under the Apache License, Version 2.0 (the "License");
5	# you may not use this file except in compliance with the License.
6	# You may obtain a copy of the License at
7	#
8	# http://www.apache.org/licenses/LICENSE-2.0
9	#
10	# Unless required by applicable law or agreed to in writing, software
11	# distributed under the License is distributed on an "AS IS" BASIS,
12	# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	# See the License for the specific language governing permissions and
14	# limitations under the License.
15
16	import logging	1✔
17
18	from twisted.internet import defer	1✔
19
20	from synapse.util.metrics import Measure	1✔
21
22	from .bulk_push_rule_evaluator import BulkPushRuleEvaluator	1✔
23
24	logger = logging.getLogger(__name__)	1✔
25
26
27	class ActionGenerator(object):	1✔
28	def __init__(self, hs):	1✔
UNCOV 29	self.hs = hs	×
UNCOV 30	self.clock = hs.get_clock()	×
UNCOV 31	self.store = hs.get_datastore()	×
UNCOV 32	self.bulk_evaluator = BulkPushRuleEvaluator(hs)	×
33	# really we want to get all user ids and all profile tags too,
34	# since we want the actions for each profile tag for every user and
35	# also actions for a client with no profile tag for each user.
36	# Currently the event stream doesn't support profile tags on an
37	# event stream, so we just run the rules for a client with no profile
38	# tag (ie. we just need all the users).
39
40	@defer.inlineCallbacks	1✔
41	def handle_push_actions_for_event(self, event, context):
UNCOV 42	with Measure(self.clock, "action_for_event_by_user"):	×
UNCOV 43	yield self.bulk_evaluator.action_for_event_by_user(event, context)	×

matrix-org / synapse / 4240

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous