1815

pending completion

Build # 1815

Build Type

Pull #2338

travis-ci

Committed by

jugglinmike

Commit Message

[[FIX]] Allow lexer to communicate completion

Currently, JSHint's lexer continuously emits new "end-of-file" token
once all input has been consumed. This behavior makes the internal
`advance` function dangerous to use within iteration contexts. Such
usages need to explicitly check for the "end-of-file" token in order to
avoid entering non-terminating states.

Some of JSHint's parsing logic (such as that for template literal
parsing) takes this detail into account. Other areas (i.e. parsing class
bodies and function parameter lists) does not. While it would be
possible to extend each use with explicit safety checks, the possibility
for error in future feature additions would remain.

Update the lexer to consistently emit `null` after producing the
"end-of-file" token, alleviating the requirement of explicit safety
checks in `advance`-calling code. Update existing unit tests with the
new parsing error information (which is more accurate in many cases).

Pull Request Pull Request #2338: [[FIX]] Allow lexer to communicate completion

Run Details

11 of 11 new or added lines in 2 files covered. (100.0%)

3678 of 3809 relevant lines covered (96.56%)

5398.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.72

/src/jshint.js

Build SHA Not Found

The commit SHA "2d1c030ac240cf0ed70c500bb9c592c55fb678de" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

jshint / jshint / 1815

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous