3706

Build # 3706

Build Type

push

jenkins

Committed by GitHub

Commit Message

<a href="https://github.com/apache/carbondata/commit/<a class=hub.com/apache/carbondata/commit/719282bef791a65a888d6f5deeb9423fe59fa4d7">719282bef<a href="https://github.com/apache/carbondata/commit/719282bef791a65a888d6f5deeb9423fe59fa4d7">">Merge </a><a class="double-link" href="https://github.com/apache/carbondata/commit/<a class="double-link" href="https://github.com/apache/carbondata/commit/ec06f68c88a20cac7a3b5580f8cb8609799647ee">ec06f68c8</a>">ec06f68c8</a><a href="https://github.com/apache/carbondata/commit/719282bef791a65a888d6f5deeb9423fe59fa4d7"> into e0743fde7">e0743fde7</a>

Run Details

273 of 273 new or added lines in 12 files covered. (100.0%)

64084 of 82869 relevant lines covered (77.33%)

1.01 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/core/src/main/java/org/apache/carbondata/core/datastore/impl/DefaultFileTypeProvider.java

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.apache.carbondata.core.datastore.impl;

import org.apache.carbondata.common.logging.LogServiceFactory;
import org.apache.carbondata.core.constants.CarbonCommonConstants;
import org.apache.carbondata.core.datastore.filesystem.AlluxioCarbonFile;
import org.apache.carbondata.core.datastore.filesystem.CarbonFile;
import org.apache.carbondata.core.datastore.filesystem.HDFSCarbonFile;
import org.apache.carbondata.core.datastore.filesystem.LocalCarbonFile;
import org.apache.carbondata.core.datastore.filesystem.S3CarbonFile;
import org.apache.carbondata.core.datastore.filesystem.ViewFSCarbonFile;
import org.apache.carbondata.core.util.CarbonProperties;

import org.apache.hadoop.conf.Configuration;
import org.apache.log4j.Logger;

/**
 * FileType provider to create CarbonFile specific to the file system where the path belongs to.
 */
public class DefaultFileTypeProvider implements FileTypeInterface {

  private static final Logger LOGGER =
      LogServiceFactory.getLogService(DefaultFileTypeProvider.class.getName());

  /**
   * Custom file type provider for supporting non default file systems.
   */
  protected FileTypeInterface customFileTypeProvider = null;

  protected boolean customFileTypeProviderInitialized = false;

  public DefaultFileTypeProvider() {
  }

  /**
   * This method is required apart from Constructor to handle the below circular dependency.
   * CarbonProperties-->FileFactory-->DefaultTypeProvider-->CarbonProperties
   */
  private void initializeCustomFileprovider() {
    if (!customFileTypeProviderInitialized) {
      customFileTypeProviderInitialized = true;
      String customFileProvider =
          CarbonProperties.getInstance().getProperty(CarbonCommonConstants.CUSTOM_FILE_PROVIDER);
      if (customFileProvider != null && !customFileProvider.trim().isEmpty()) {
        try {
          customFileTypeProvider =
              (FileTypeInterface) Class.forName(customFileProvider).newInstance();
        } catch (Exception e) {
          LOGGER.error("Unable load configured FileTypeInterface class. Ignored.", e);
        }
      }
    }
  }

  /**
   * Delegate to the custom file provider to check if the path is supported or not.
   * Note this function do not check the default supported file systems as  #getCarbonFile expects
   * this method output is from customFileTypeProvider.
   *
   * @param path path of the file
   * @return true if supported by the custom
   */
  @Override public boolean isPathSupported(String path) {
    initializeCustomFileprovider();
    if (customFileTypeProvider != null) {
      return customFileTypeProvider.isPathSupported(path);
    }
    return false;
  }

  public CarbonFile getCarbonFile(String path, Configuration conf) {
    // Handle the custom file type first
    if (isPathSupported(path)) {
      return customFileTypeProvider.getCarbonFile(path, conf);
    }

    FileFactory.FileType fileType = FileFactory.getFileType(path);
    switch (fileType) {
      case LOCAL:
        return new LocalCarbonFile(FileFactory.getUpdatedFilePath(path, fileType));
      case HDFS:
        return new HDFSCarbonFile(path, conf);
      case S3:
        return new S3CarbonFile(path, conf);
      case ALLUXIO:
        return new AlluxioCarbonFile(path);
      case VIEWFS:
        return new ViewFSCarbonFile(path);
      default:
        return new LocalCarbonFile(FileFactory.getUpdatedFilePath(path, fileType));
    }
  }
}

1	/*
2	* Licensed to the Apache Software Foundation (ASF) under one or more
3	* contributor license agreements. See the NOTICE file distributed with
4	* this work for additional information regarding copyright ownership.
5	* The ASF licenses this file to You under the Apache License, Version 2.0
6	* (the "License"); you may not use this file except in compliance with
7	* the License. You may obtain a copy of the License at
8	*
9	* http://www.apache.org/licenses/LICENSE-2.0
10	*
11	* Unless required by applicable law or agreed to in writing, software
12	* distributed under the License is distributed on an "AS IS" BASIS,
13	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14	* See the License for the specific language governing permissions and
15	* limitations under the License.
16	*/
17
18	package org.apache.carbondata.core.datastore.impl;
19
20	import org.apache.carbondata.common.logging.LogServiceFactory;
21	import org.apache.carbondata.core.constants.CarbonCommonConstants;
22	import org.apache.carbondata.core.datastore.filesystem.AlluxioCarbonFile;
23	import org.apache.carbondata.core.datastore.filesystem.CarbonFile;
24	import org.apache.carbondata.core.datastore.filesystem.HDFSCarbonFile;
25	import org.apache.carbondata.core.datastore.filesystem.LocalCarbonFile;
26	import org.apache.carbondata.core.datastore.filesystem.S3CarbonFile;
27	import org.apache.carbondata.core.datastore.filesystem.ViewFSCarbonFile;
28	import org.apache.carbondata.core.util.CarbonProperties;
29
30	import org.apache.hadoop.conf.Configuration;
31	import org.apache.log4j.Logger;
32
33	/**
34	* FileType provider to create CarbonFile specific to the file system where the path belongs to.
35	*/
36	public class DefaultFileTypeProvider implements FileTypeInterface {
37
38	private static final Logger LOGGER =	2✔
39	LogServiceFactory.getLogService(DefaultFileTypeProvider.class.getName());	2✔
40
41	/**
42	* Custom file type provider for supporting non default file systems.
43	*/
44	protected FileTypeInterface customFileTypeProvider = null;	2✔
45
46	protected boolean customFileTypeProviderInitialized = false;	2✔
47
48	public DefaultFileTypeProvider() {	2✔
49	}	2✔
50
51	/**
52	* This method is required apart from Constructor to handle the below circular dependency.
53	* CarbonProperties-->FileFactory-->DefaultTypeProvider-->CarbonProperties
54	*/
55	private void initializeCustomFileprovider() {
56	if (!customFileTypeProviderInitialized) {	2✔
57	customFileTypeProviderInitialized = true;	2✔
58	String customFileProvider =
59	CarbonProperties.getInstance().getProperty(CarbonCommonConstants.CUSTOM_FILE_PROVIDER);	2✔
60	if (customFileProvider != null && !customFileProvider.trim().isEmpty()) {	2✔
61	try {
62	customFileTypeProvider =	2✔
63	(FileTypeInterface) Class.forName(customFileProvider).newInstance();	2✔
64	} catch (Exception e) {	2✔
65	LOGGER.error("Unable load configured FileTypeInterface class. Ignored.", e);	2✔
66	}	2✔
67	}
68	}
69	}	2✔
70
71	/**
72	* Delegate to the custom file provider to check if the path is supported or not.
73	* Note this function do not check the default supported file systems as #getCarbonFile expects
74	* this method output is from customFileTypeProvider.
75	*
76	* @param path path of the file
77	* @return true if supported by the custom
78	*/
79	@Override public boolean isPathSupported(String path) {
80	initializeCustomFileprovider();	2✔
81	if (customFileTypeProvider != null) {	2✔
82	return customFileTypeProvider.isPathSupported(path);	2✔
83	}
84	return false;	2✔
85	}
86
87	public CarbonFile getCarbonFile(String path, Configuration conf) {
88	// Handle the custom file type first
89	if (isPathSupported(path)) {	2✔
90	return customFileTypeProvider.getCarbonFile(path, conf);	2✔
91	}
92
93	FileFactory.FileType fileType = FileFactory.getFileType(path);	2✔
94	switch (fileType) {	2✔
95	case LOCAL:
96	return new LocalCarbonFile(FileFactory.getUpdatedFilePath(path, fileType));	2✔
97	case HDFS:
98	return new HDFSCarbonFile(path, conf);	×
99	case S3:
100	return new S3CarbonFile(path, conf);	×
101	case ALLUXIO:
102	return new AlluxioCarbonFile(path);	×
103	case VIEWFS:
104	return new ViewFSCarbonFile(path);	×
105	default:
106	return new LocalCarbonFile(FileFactory.getUpdatedFilePath(path, fileType));	×
107	}
108	}
109	}

apache / carbondata / 3706

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous