enkessler / childprocess / 447

pending completion

Build # 447

Build Type

Pull #152

travis-ci

Committed by

web-flow

Commit Message

Fix ChildProcess::Unix::Process#wait method with leader processes

Issue #151 reported a problem where in the update from Ruby 2.5 to Ruby
2.6 some programs would block forever on a `Process.waitpid2` call.

Changing the call to pass in a positive PID instead of the negative PID
fixes the issue as it will call the `waitpid` system call right away
instead of delaying it for later.

See #151 for further discussion of the possible reasons for the
behavior.

Pull Request Pull Request #152: Fix ChildProcess::Unix::Process#wait method with leader processes

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

805 of 891 relevant lines covered (90.35%)

449.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.44

/lib/childprocess/abstract_io.rb

module ChildProcess
  class AbstractIO
    attr_reader :stderr, :stdout, :stdin

    def inherit!
      @stdout = STDOUT
      @stderr = STDERR
    end

    def stderr=(io)
      check_type io
      @stderr = io
    end

    def stdout=(io)
      check_type io
      @stdout = io
    end

    #
    # @api private
    #

    def _stdin=(io)
      check_type io
      @stdin = io
    end

    private

    def check_type(io)
      raise SubclassResponsibility, "check_type"
    end

  end
end

1	module ChildProcess	20✔
2	class AbstractIO	20✔
3	attr_reader :stderr, :stdout, :stdin	20✔
4
5	def inherit!	20✔
6	@stdout = STDOUT	40✔
7	@stderr = STDERR	40✔
8	end
9
10	def stderr=(io)	20✔
11	check_type io	120✔
12	@stderr = io	120✔
13	end
14
15	def stdout=(io)	20✔
16	check_type io	220✔
17	@stdout = io	200✔
18	end
19
20	#
21	# @api private
22	#
23
24	def _stdin=(io)	20✔
25	check_type io	60✔
26	@stdin = io	60✔
27	end
28
29	private	20✔
30
31	def check_type(io)	20✔
32	raise SubclassResponsibility, "check_type"	×
33	end
34
35	end
36	end

enkessler / childprocess / 447

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous