miloyip / rapidjson / 758

pending completion

Build # 758

Build Type

Pull #305

travis-ci

Committed by

pah

Commit Message

Avoid calling memcpy with NULL pointers

According to the C/C++ standards, calling `memcpy(NULL, NULL, 0)` is
undefined behaviour. Recent GCC versions may rely on this by optimizing
NULL pointer checks more aggressively, see [1].

This patch tries to avoid calling std::memcpy with zero elements.
As a side effect, explicitly return NULL when requesting an empty block
from MemoryPoolAllocator::Malloc.

This may be related to #301.

[1] https://gcc.gnu.org/gcc-4.9/porting_to.html

Pull Request Pull Request #305: Avoid calling memcpy with NULL pointers

Run Details

2383 of 2384 relevant lines covered (99.96%)

2646913.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.57

/include/rapidjson/allocators.h

Build SHA Not Found

The commit SHA "b34b48b890b4b64e4423047b55a34ee70b26eb60" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

miloyip / rapidjson / 758

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous