1106

pending completion

Build # 1106

Build Type

Pull #121

travis-ci-com

Committed by

web-flow

Commit Message

Fix metric name of IP pool in metrics

8cf5938 introduced IP pool metrics. Upon accessing these metrics via the
Prometheus format, the following invalid metric name is created:

    pool_<<"sgi">>_ipv4_10_0_0_1_free 262112

The invalid part `<<"sgi">>` is caused by http_api_handler:ioize/1. This
commit fixes the function to produce:

    pool_sgi_ipv4_10_0_0_1_free 262112

In addition, pools for IPv6 addresses would create an invalid metric
name for Prometheus (see [1]). By converting the ":" to "_", this is
fixed as well.

[1]: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

Pull Request Pull Request #121: Fix metric name of IP pool in metrics

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

3662 of 4649 relevant lines covered (78.77%)

3842.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.05

/src/http_api_handler.erl

Build SHA Not Found

The commit SHA "acf354cd0d0c2f1ee2b294d44468b11e7d59833e" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

travelping / ergw / 1106

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous