24411288

Build Type

push

appveyor

Committed by GitHub

Commit Message

<a href="https://github.com/benmosher/eslint-plugin-import/commit/<a class=hub.com/benmosher/eslint-plugin-import/commit/b5ac8bca39fd95b95cb76b55e7ddb4dab0921f1d">b5ac8bca3<a href="https://github.com/benmosher/eslint-plugin-import/commit/b5ac8bca39fd95b95cb76b55e7ddb4dab0921f1d">">Merge </a><a class="double-link" href="https://github.com/benmosher/eslint-plugin-import/commit/<a class="double-link" href="https://github.com/benmosher/eslint-plugin-import/commit/b953a14144733039449fbbc66f3d6ed6b795e504">b953a1414</a>">b953a1414</a><a href="https://github.com/benmosher/eslint-plugin-import/commit/b5ac8bca39fd95b95cb76b55e7ddb4dab0921f1d"> into 1edbbd03e">1edbbd03e</a>

Run Details

1309 of 1435 branches covered (91.22%)

22 of 22 new or added lines in 1 file covered. (100.0%)

1916 of 2009 relevant lines covered (95.37%)

48.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.89

/src/rules/max-depth.js

import isStaticRequire from '../core/staticRequire'
import docsUrl from '../docsUrl'

const DEFAULT_MAX = 0

const createError = (sourcePath, maxDepth, actualDepth) => (
  `Import '${sourcePath}' exceeds max nesting depth of ${maxDepth} (actual: ${actualDepth}).`
)

const checkDepth = (sourceValue, node, context) => {
  const {max = DEFAULT_MAX, overridePackages = {}} = context.options[0] || { }
  let packageMax = max

  if (/^\./.test(sourceValue)) {
    // skip relative paths
    return
  }

  let [pkgName, ...dirs] = sourceValue.split('/')

  // update variables for scoped packages
  if (/^@/.test(pkgName)) {
      pkgName = `${pkgName}/${dirs[0]}`
      dirs = dirs.slice(1)
  }

  if (pkgName in overridePackages) {
    packageMax = overridePackages[pkgName]
  }

  if (dirs.length > packageMax) {
      context.report({
          node,
          message: createError(sourceValue, packageMax, dirs.length),
      })
  }
}

module.exports = {
  meta: {
    type: 'suggestion',
    docs: {
      url: docsUrl('max-depth'),
    },
    schema: [
      {
          type: 'object',
          properties: {
              overridePackages: {
                  type: 'object',
                  patternProperties: {
                      '^[a-zA-Z-_@/]+$': {
                          type: 'integer',
                          minimum: 0,
                      },
                  },
                  additionalProperties: false,
              },
              max: {
                  type: 'integer',
                  minimum: 0,
              },
          },
          additionalProperties: false,
      },
    ],
  },

  create: context => {

    return {
      ImportDeclaration(node) {
        checkDepth(node.source.value, node.source, context)
      },
      CallExpression(node) {
        if (isStaticRequire(node)) {
            const [ requirePath ] = node.arguments
            checkDepth(requirePath.value, node, context)
        }
      },
    }
  },
}

1	import isStaticRequire from '../core/staticRequire'
2	import docsUrl from '../docsUrl'
3
4	const DEFAULT_MAX = 0	1✔
5
6	const createError = (sourcePath, maxDepth, actualDepth) => (	1✔
7	`Import '${sourcePath}' exceeds max nesting depth of ${maxDepth} (actual: ${actualDepth}).`	3✔
8	)
9
10	const checkDepth = (sourceValue, node, context) => {	1✔
11	const {max = DEFAULT_MAX, overridePackages = {}} = context.options[0] \|\| { }	14✔
12	let packageMax = max	14✔
13
14	if (/^\./.test(sourceValue)) {	14✔
15	// skip relative paths
16	return	6✔
17	}
18
19	let [pkgName, ...dirs] = sourceValue.split('/')	8✔
20
21	// update variables for scoped packages
22	if (/^@/.test(pkgName)) {	8!
23	pkgName = `${pkgName}/${dirs[0]}`	×
24	dirs = dirs.slice(1)	×
25	}
26
27	if (pkgName in overridePackages) {	8✔
28	packageMax = overridePackages[pkgName]	2✔
29	}
30
31	if (dirs.length > packageMax) {	8✔
32	context.report({	3✔
33	node,
34	message: createError(sourceValue, packageMax, dirs.length),
35	})
36	}
37	}
38
39	module.exports = {	1✔
40	meta: {
41	type: 'suggestion',
42	docs: {
43	url: docsUrl('max-depth'),
44	},
45	schema: [
46	{
47	type: 'object',
48	properties: {
49	overridePackages: {
50	type: 'object',
51	patternProperties: {
52	'^[a-zA-Z-_@/]+$': {
53	type: 'integer',
54	minimum: 0,
55	},
56	},
57	additionalProperties: false,
58	},
59	max: {
60	type: 'integer',
61	minimum: 0,
62	},
63	},
64	additionalProperties: false,
65	},
66	],
67	},
68
69	create: context => {
70
71	return {	14✔
72	ImportDeclaration(node) {
73	checkDepth(node.source.value, node.source, context)	11✔
74	},
75	CallExpression(node) {
76	if (isStaticRequire(node)) {	3!
77	const [ requirePath ] = node.arguments	3✔
78	checkDepth(requirePath.value, node, context)	3✔
79	}
80	},
81	}
82	},
83	}

benmosher / eslint-plugin-import / 24411288

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous