splitgraph / splitgraph / 132

pending completion

Build # 132

Build Type

Pull #60

travis-ci

Committed by

web-flow

Commit Message

Include the parent ID in the hash that is used to calculate the new fragment ID.

This is for when the same action (with the same old and new rows) is performed on the two different versions of a table with the same schema: due to the way the object tree works, that pulls in all of the object's parents at materialization time (see test_diff_fragment_hashing_reused_twice), resulting in the table being stored incorrectly.

Whilst this might waste space, this shouldn't happen often. Alternatives would be:

 * including all of the fragments a table consists of in its metadata (as opposed to tips of object tree chains) -- would consume a lot of extra space for tables with a lot of changes
 * adding another indirection:
   * an object tree with nodes that point to actual objects (multiple nodes can point to the same object)
   * every node has a parent showing which node a given object should be applied to
   * tables now point to nodes in this tree rather than actual objects
   * this would be more difficult to maintain (extra work at object creation and materialization time) + overhead from another metadata table.

Pull Request Pull Request #60: Deterministic object IDs

Run Details

1387 of 1482 branches covered (93.59%)

Branch coverage included in aggregate %.

177 of 177 new or added lines in 11 files covered. (100.0%)

2985 of 3090 relevant lines covered (96.6%)

0.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/splitgraph/core/metadata_manager.py

Build SHA Not Found

The commit SHA "fcab9299eeeb7a76b1db3b9b6300a7a5743c75cc" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

splitgraph / splitgraph / 132

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous