sonata-project / SonataTranslationBundle / 986

pending completion

Build # 986

Build Type

cron

travis-ci

Committed by

greg0ire

Commit Message

<a href="https://github.com/sonata-project/SonataTranslationBundle/commit/<a class=hub.com/sonata-project/SonataTranslationBundle/commit/1be65fa3d39ed779d0a6f711b5f80fc00209234b">1be65fa3d<a href="https://github.com/sonata-project/SonataTranslationBundle/commit/1be65fa3d39ed779d0a6f711b5f80fc00209234b">&quot;&gt;Make it possible to create an admin without entity

Currently when creating an admin with no entity (`~` as argument), the [get_class](https://github.com/storefront-bvba/SonataTranslationBundle/blob/</a><a class="double-link" href="https://github.com/sonata-project/SonataTranslationBundle/commit/<a class="double-link" href="https://github.com/sonata-project/SonataTranslationBundle/commit/af09eb0f51162ae05c5365835869f4ddfeed9a98">af09eb0f5</a>">af09eb0f5</a><a href="https://github.com/sonata-project/SonataTranslationBundle/commit/1be65fa3d39ed779d0a6f711b5f80fc00209234b">/src/DependencyInjection/Compiler/AdminExtensionCompilerPass.php#L36) throws `class_exists() expects parameter 1 to be string`. To overcome this I would first check if there's a model class and after that check if it exists.

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

226 of 446 relevant lines covered (50.67%)

9.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/DependencyInjection/Compiler/AdminExtensionCompilerPass.php

<?php

declare(strict_types=1);

/*
 * This file is part of the Sonata Project package.
 *
 * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Sonata\TranslationBundle\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Reference;

/**
 * @author Nicolas Bastien <nbastien@prestaconcept.net>
 */
class AdminExtensionCompilerPass implements CompilerPassInterface
{
    /**
     * {@inheritdoc}
     */
    public function process(ContainerBuilder $container)
    {
        $translationTargets = $container->getParameter('sonata_translation.targets');
        $adminExtensionReferences = $this->getAdminExtensionReferenceByTypes(array_keys($translationTargets));

        foreach ($container->findTaggedServiceIds('sonata.admin') as $id => $attributes) {
            $admin = $container->getDefinition($id);
            $modelClass = $container->getParameterBag()->resolveValue($admin->getArgument(1));
            if (!$modelClass || !class_exists($modelClass)) {
                continue;
            }
            $modelClassReflection = new \ReflectionClass($modelClass);

            foreach ($adminExtensionReferences as $type => $reference) {
                foreach ($translationTargets[$type]['implements'] as $interface) {
                    if ($modelClassReflection->implementsInterface($interface)) {
                        $admin->addMethodCall('addExtension', [$reference]);
                    }
                }
                foreach ($translationTargets[$type]['instanceof'] as $class) {
                    if ($modelClassReflection->getName() === $class || $modelClassReflection->isSubclassOf($class)) {
                        $admin->addMethodCall('addExtension', [$reference]);
                    }
                }
            }
        }
    }

    /**
     * @param array $types
     *
     * @return Reference[]
     */
    protected function getAdminExtensionReferenceByTypes(array $types)
    {
        $references = [];
        foreach ($types as $type) {
            $references[$type] = new Reference('sonata_translation.admin.extension.'.$type.'_translatable');
        }

        return $references;
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	/*
6	* This file is part of the Sonata Project package.
7	*
8	* (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
9	*
10	* For the full copyright and license information, please view the LICENSE
11	* file that was distributed with this source code.
12	*/
13
14	namespace Sonata\TranslationBundle\DependencyInjection\Compiler;
15
16	use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
17	use Symfony\Component\DependencyInjection\ContainerBuilder;
18	use Symfony\Component\DependencyInjection\Reference;
19
20	/**
21	* @author Nicolas Bastien <nbastien@prestaconcept.net>
22	*/
23	class AdminExtensionCompilerPass implements CompilerPassInterface
24	{
25	/**
26	* {@inheritdoc}
27	*/
28	public function process(ContainerBuilder $container)
29	{	×
30	$translationTargets = $container->getParameter('sonata_translation.targets');	×
31	$adminExtensionReferences = $this->getAdminExtensionReferenceByTypes(array_keys($translationTargets));	×
32
33	foreach ($container->findTaggedServiceIds('sonata.admin') as $id => $attributes) {	×
34	$admin = $container->getDefinition($id);	×
35	$modelClass = $container->getParameterBag()->resolveValue($admin->getArgument(1));	×
36	if (!$modelClass \|\| !class_exists($modelClass)) {	×
37	continue;	×
38	}	×
39	$modelClassReflection = new \ReflectionClass($modelClass);	×
40
41	foreach ($adminExtensionReferences as $type => $reference) {	×
42	foreach ($translationTargets[$type]['implements'] as $interface) {	×
43	if ($modelClassReflection->implementsInterface($interface)) {	×
44	$admin->addMethodCall('addExtension', [$reference]);	×
45	}	×
46	}	×
47	foreach ($translationTargets[$type]['instanceof'] as $class) {	×
48	if ($modelClassReflection->getName() === $class \|\| $modelClassReflection->isSubclassOf($class)) {	×
49	$admin->addMethodCall('addExtension', [$reference]);	×
50	}	×
51	}	×
52	}	×
53	}	×
54	}	×
55
56	/**
57	* @param array $types
58	*
59	* @return Reference[]
60	*/
61	protected function getAdminExtensionReferenceByTypes(array $types)
62	{	×
63	$references = [];	×
64	foreach ($types as $type) {	×
65	$references[$type] = new Reference('sonata_translation.admin.extension.'.$type.'_translatable');	×
66	}	×
67
68	return $references;	×
69	}	×
70	}

sonata-project / SonataTranslationBundle / 986

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous