2117

pending completion

Build # 2117

Build Type

Pull #2164

travis-ci

Committed by

shawncatz

Commit Message

fix missing record data in dynect dns

currently, when fog requests all records:
* make a NodeList request
returns a list of nodes (domains)
* for each domain, make a secondary AnyRecord request for each domain
returns a list of records (without data)

The resulting Record objects do not contain the data of where the record points (address or cname). 'rdata' is nil

I've changed the process to be:
* make an AllRecord request
returns a list of records (without data)
* make a secondary request to *Record (using the type returned from the AllRecord request)
this returns a *complete* record object (including data)

The number of requests to Dynect API is the same, but the resulting objects contain all of the information.

TODO:
* Please help me integrate with fog testing
* I had to remove (comment) the API Version header, not sure what the correct value for this is
** Dynect documentation is a bit difficult to work through

Pull Request Pull Request #2164: fix missing record data in dynect dns

Run Details

31 of 31 new or added lines in 3 files covered. (100.0%)

36068 of 54079 relevant lines covered (66.7%)

105.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.16

/lib/fog/dynect/dns.rb

Build SHA Not Found

The commit SHA "c4d1ef93610e433a5b02cd9a031b8b9d9013f5dd" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

fog / fog / 2117

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous