19826

pending completion

Build # 19826

Build Type

Pull #6766

travis-ci

Committed by

web-flow

Commit Message

fix(list-view): Cast docnames to str before sorting

In Python 3 str and non-str comparison is not allowed.

Bulk delete operation fails when selected docnames meet following condition
1. at least on name can be casted to int or other types e.g. "1", "3123423524", "1.0"
2. at least on name that cannot be casted to other types e.g. "A", "56cd83dab1"

The root cause is $.data() which forcefully casts data-name to non string types when possible

Pull Request Pull Request #6766: fix(list-view): Cast docnames to str before sorting

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

17505 of 38756 relevant lines covered (45.17%)

0.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

8.5

/frappe/desk/reportview.py

Build SHA Not Found

The commit SHA "8eea4c7a7b841850abf59f3b4af0f5273e0d6701" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

frappe / frappe / 19826

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous