wikimedia / restbase / 883

pending completion

Build # 883

Build Type

Pull #205

travis-ci

Committed by

gwicke

Commit Message

Don't swallow & generate content for non-404 errors

The unconditional catch handler in parsoid.js triggered content generation on
*any* errors, not just 404s. This led to a large number of revisions to be
stored on some pages I was using for benchmarking.

It also covered up a bug in the handling of requests for 'latest' revisions.
The frontend code (and a test) was creating internal requests with 'latest' as
the revision, but the revision parsing code in key_rev_value did not consider
that a valid revision. Combined with the earlier bug this meant that each
request for an existing version was causing a new revision to be parsed &
saved.

This patch solves both problems by

- only generating content on 404, and re-raising any other errors, and

- dropping the `/latest` pseudo-revision in favor of a straight request for
  the title.

Pull Request Pull Request #205: Cassandra driver v2 fixes / tweaks

Run Details

27 of 27 new or added lines in 3 files covered. (100.0%)

741 of 857 relevant lines covered (86.46%)

72.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.48

/mods/parsoid.js

Build SHA Not Found

The commit SHA "525dc8b256d8bf37b4573fa26e78d539820a8551" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

wikimedia / restbase / 883

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous