qbeon / webwire-go / 351

Committed 16 Nov 2018 04:37PM UTC coverage: 69.617% (-12.0%) from 81.571%

Build # 351

Build Type

Pull #37

travis-ci

Committed by

web-flow

Commit Message

Fix bug and improve performance

Reuse the dial timer in the client to avoid unnecessary reallocations.
Check connection status before reading in the fasthttp/websocket
transport implementation. Replace the IsAbnormalCloseErr with IsCloseErr
method in the SockReadErr interface.

Pull Request Pull Request #37: Introduce transport layer abstraction

Run Details

2280 of 2280 new or added lines in 97 files covered. (100.0%)

2690 of 3864 relevant lines covered (69.62%)

571.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.62

/message/parseConf.go

package message

import (
        "encoding/binary"
        "errors"
        "time"
)

// parseConf parses MsgConf messages
func (msg *Message) parseConf() error {
        if msg.MsgBuffer.len < MsgMinLenConf {
                return errors.New("invalid msg length, too short")
        }
        msg.ServerConfiguration = ServerConfiguration{
                MajorProtocolVersion: msg.MsgBuffer.buf[1:2][0],
                MinorProtocolVersion: msg.MsgBuffer.buf[2:3][0],
                ReadTimeout: time.Duration(
                        binary.LittleEndian.Uint32(msg.MsgBuffer.buf[3:7]),
                ) * time.Millisecond,
                MessageBufferSize: binary.LittleEndian.Uint32(msg.MsgBuffer.buf[7:11]),
        }
        return nil
}

1	package message
2
3	import (
4	"encoding/binary"
5	"errors"
6	"time"
7	)
8
9	// parseConf parses MsgConf messages
10	func (msg *Message) parseConf() error {	196✔
11	if msg.MsgBuffer.len < MsgMinLenConf {	196✔
12	return errors.New("invalid msg length, too short")	×
13	}	×
14	msg.ServerConfiguration = ServerConfiguration{	196✔
15	MajorProtocolVersion: msg.MsgBuffer.buf[1:2][0],	196✔
16	MinorProtocolVersion: msg.MsgBuffer.buf[2:3][0],	196✔
17	ReadTimeout: time.Duration(	196✔
18	binary.LittleEndian.Uint32(msg.MsgBuffer.buf[3:7]),	196✔
19	) * time.Millisecond,	196✔
20	MessageBufferSize: binary.LittleEndian.Uint32(msg.MsgBuffer.buf[7:11]),	196✔
21	}	196✔
22	return nil	196✔
23	}

qbeon / webwire-go / 351

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous