3892

pending completion

Build # 3892

Build Type

Pull #1038

travis-ci

Committed by

web-flow

Commit Message

[SDESK-3491] Save latest coverage type desk as user preference to use it when creating new coverages

Pull Request Pull Request #1038: [SDESK-3491] Save latest coverage type desk as user preference to use it when creating new coverages

Run Details

6398 of 12664 branches covered (50.52%)

29 of 29 new or added lines in 8 files covered. (100.0%)

18049 of 24951 relevant lines covered (72.34%)

5.27 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.55

/client/components/Assignments/AssignmentPopup/index.jsx

import React from 'react';
import PropTypes from 'prop-types';

import {set, cloneDeep} from 'lodash';
import {gettext} from '../../../utils';

import {ButtonList} from '../../UI';
import {Popup, Header, Footer, Content} from '../../UI/Popup';
import {AssignmentEditor} from '../AssignmentEditor';

import './style.scss';

export class AssignmentPopup extends React.Component {
    constructor(props) {
        super(props);

        this.state = {
            diff: cloneDeep(props.value) || {},
            valid: true,
        };
        this.dom = {popupContainer: null};

        this.onChange = this.onChange.bind(this);
        this.onSubmit = this.onSubmit.bind(this);
        this.getPopupContainer = this.getPopupContainer.bind(this);
        this.setValid = this.setValid.bind(this);
    }

    onChange(field, value) {
        const diff = cloneDeep(this.state.diff);

        set(diff, field, value);
        this.setState({diff});
    }

    onSubmit() {
        this.props.onChange(this.props.field, this.state.diff);
        this.props.setCoverageDefaultDesk(this.state.diff);
        this.props.onClose();
    }

    getPopupContainer() {
        return this.dom.popupContainer;
    }

    setValid(valid) {
        this.setState({valid});
    }

    render() {
        const {
            onClose,
            target,
            users,
            desks,
            coverageProviders,
            priorities,
            priorityPrefix,
            disableDeskSelection,
            disableUserSelection,
            popupContainer,
            onPopupOpen,
            onPopupClose,
        } = this.props;

        const {diff} = this.state;

        const buttonList = [{
            color: 'primary',
            onClick: this.onSubmit,
            disabled: !this.state.valid,
            text: gettext('OK'),
            enterKeyIsClick: true,
            id: 'submitAssignment',
        },
        {
            onClick: onClose,
            text: gettext('Cancel'),
            enterKeyIsClick: true,
        }];

        return (
            <Popup
                close={onClose}
                target={target}
                className="assignment-popup"
                onKeyDown={this.onKeyDown}
                popupContainer={popupContainer}
                onPopupOpen={onPopupOpen}
                onPopupClose={onPopupClose}
            >
                <Header text={gettext('Assignment Details')} onClose={onClose} />
                <Content>
                    <AssignmentEditor
                        value={diff}
                        onChange={this.onChange}
                        onClose={onClose}
                        users={users}
                        desks={desks}
                        coverageProviders={coverageProviders}
                        priorities={priorities}
                        priorityPrefix={priorityPrefix}
                        popupContainer={this.getPopupContainer}
                        disableDeskSelection={disableDeskSelection}
                        disableUserSelection={disableUserSelection}
                        setValid={this.setValid}
                    />
                </Content>
                <Footer>
                    <ButtonList buttonList={buttonList} captureShiftTab={false} />
                </Footer>
                <div ref={(node) => this.dom.popupContainer = node} />
            </Popup>
        );
    }
}

AssignmentPopup.propTypes = {
    field: PropTypes.string,
    value: PropTypes.object,
    onChange: PropTypes.func,
    onClose: PropTypes.func,
    target: PropTypes.string,
    users: PropTypes.array,
    desks: PropTypes.array,
    coverageProviders: PropTypes.array,
    priorities: PropTypes.array,
    priorityPrefix: PropTypes.string,
    disableDeskSelection: PropTypes.bool,
    disableUserSelection: PropTypes.bool,
    popupContainer: PropTypes.func,
    onPopupOpen: PropTypes.func,
    onPopupClose: PropTypes.func,
    setCoverageDefaultDesk: PropTypes.func,
};

AssignmentPopup.defaultProps = {priorityPrefix: ''};

1	import React from 'react';
2	import PropTypes from 'prop-types';	1✔
3		1✔
4	import {set, cloneDeep} from 'lodash';	1!
5	import {gettext} from '../../../utils';	×
6		×
7	import {ButtonList} from '../../UI';	1✔
8	import {Popup, Header, Footer, Content} from '../../UI/Popup';
9	import {AssignmentEditor} from '../AssignmentEditor';	1✔
10		1✔
11	import './style.scss';	1✔
12		1!
13	export class AssignmentPopup extends React.Component {
14	constructor(props) {
15	super(props);	1✔
16		2!
17	this.state = {
18	diff: cloneDeep(props.value) \|\| {},	1✔
19	valid: true,	1✔
20	};	1✔
21	this.dom = {popupContainer: null};	1✔
22		1✔
23	this.onChange = this.onChange.bind(this);	1✔
24	this.onSubmit = this.onSubmit.bind(this);	1✔
25	this.getPopupContainer = this.getPopupContainer.bind(this);	1✔
26	this.setValid = this.setValid.bind(this);	1✔
27	}	1✔
28		1✔
29	onChange(field, value) {	1✔
30	const diff = cloneDeep(this.state.diff);	×
31		×
32	set(diff, field, value);	×
33	this.setState({diff});
34	}
35		×
36	onSubmit() {	×
37	this.props.onChange(this.props.field, this.state.diff);	×
38	this.props.setCoverageDefaultDesk(this.state.diff);	×
39	this.props.onClose();	×
40	}	×
41
42	getPopupContainer() {	1✔
43	return this.dom.popupContainer;	×
44	}	×
45		×
46	setValid(valid) {
47	this.setState({valid});	1✔
48	}	×
49		×
50	render() {	×
51	const {
52	onClose,	1✔
53	target,	×
54	users,
55	desks,	1✔
56	coverageProviders,	×
57	priorities,
58	priorityPrefix,	1✔
59	disableDeskSelection,	×
60	disableUserSelection,	×
61	popupContainer,	×
62	onPopupOpen,	×
63	onPopupClose,
64	} = this.props;
65
66	const {diff} = this.state;
67
68	const buttonList = [{
69	color: 'primary',
70	onClick: this.onSubmit,
71	disabled: !this.state.valid,
72	text: gettext('OK'),
73	enterKeyIsClick: true,
74	id: 'submitAssignment',
75	},	×
76	{
77	onClick: onClose,
78	text: gettext('Cancel'),
79	enterKeyIsClick: true,
80	}];
81		×
82	return (
83	<Popup	1✔
84	close={onClose}
85	target={target}	1✔
86	className="assignment-popup"	1✔
87	onKeyDown={this.onKeyDown}
88	popupContainer={popupContainer}
89	onPopupOpen={onPopupOpen}
90	onPopupClose={onPopupClose}
91	>
92	<Header text={gettext('Assignment Details')} onClose={onClose} />
93	<Content>
94	<AssignmentEditor
95	value={diff}
96	onChange={this.onChange}
97	onClose={onClose}
98	users={users}
99	desks={desks}
100	coverageProviders={coverageProviders}
101	priorities={priorities}
102	priorityPrefix={priorityPrefix}
103	popupContainer={this.getPopupContainer}
104	disableDeskSelection={disableDeskSelection}	1✔
105	disableUserSelection={disableUserSelection}
106	setValid={this.setValid}
107	/>
108	</Content>
109	<Footer>
110	<ButtonList buttonList={buttonList} captureShiftTab={false} />
111	</Footer>
112	<div ref={(node) => this.dom.popupContainer = node} />
113	</Popup>
114	);
115	}
116	}
117
118	AssignmentPopup.propTypes = {
119	field: PropTypes.string,
120	value: PropTypes.object,
121	onChange: PropTypes.func,
122	onClose: PropTypes.func,
123	target: PropTypes.string,
124	users: PropTypes.array,
125	desks: PropTypes.array,
126	coverageProviders: PropTypes.array,
127	priorities: PropTypes.array,
128	priorityPrefix: PropTypes.string,
129	disableDeskSelection: PropTypes.bool,
130	disableUserSelection: PropTypes.bool,
131	popupContainer: PropTypes.func,
132	onPopupOpen: PropTypes.func,
133	onPopupClose: PropTypes.func,
134	setCoverageDefaultDesk: PropTypes.func,
135	};
136
137	AssignmentPopup.defaultProps = {priorityPrefix: ''};

superdesk / superdesk-planning / 3892

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous