2253

pending completion

Build # 2253

Build Type

Pull #448

travis-ci

Committed by

web-flow

Commit Message

[MIG] stock_picking_package_preparation: Migration to 11.0

manifest

Substitute stock.pack.operation with stock.move.line, after https://github.com/odoo/odoo/commit/ddf2b21bd

Removing children_ids after https://github.com/odoo/odoo/commit/809605bb8

product packaging gets a variant instead of a template after https://github.com/odoo/odoo/commit/796900feb

get_content becomes get_contained_quants

test little refactoring

qty becomes quantity in stock.quant

Pull Request Pull Request #448: 11.0 mig stock picking package preparation

Run Details

87 of 87 new or added lines in 1 file covered. (100.0%)

295 of 331 relevant lines covered (89.12%)

1.78 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.01

/stock_picking_package_preparation/models/stock_picking_package_preparation.py

# Copyright 2015 Guewen Baconnier
# Copyright 2016 Lorenzo Battistini - Agile Business Group
# Copyright 2016 Alessio Gerace - Agile Business Group
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from odoo import models, fields, api, _
from odoo.exceptions import Warning as UserError


class StockPickingPackagePreparation(models.Model):
    _name = 'stock.picking.package.preparation'
    _description = 'Package Preparation'
    _inherit = ['mail.thread']

    FIELDS_STATES = {'done': [('readonly', True)],
                     'in_pack': [('readonly', True)],
                     'cancel': [('readonly', True)]}

    def _default_company_id(self):
        company_model = self.env['res.company']
        return company_model._company_default_get(self._name)

    name = fields.Char(
        related='package_id.name',
        readonly=True,
        index=True,
        store=True,
    )
    state = fields.Selection(
        selection=[('draft', 'Draft'),
                   ('cancel', 'Cancelled'),
                   ('in_pack', 'In Pack'),
                   ('done', 'Done'),
                   ],
        default='draft',
        string='State',
        readonly=True,
        copy=False,
    )
    partner_id = fields.Many2one(
        comodel_name='res.partner',
        string='Partner',
        required=True,
        states=FIELDS_STATES,
    )
    picking_ids = fields.Many2many(
        comodel_name='stock.picking',
        relation='stock_picking_pack_prepare_rel',
        column1='stock_picking_package_preparation_id',
        column2='stock_picking_id',
        string='Transfers',
        copy=False,
        states=FIELDS_STATES,
    )
    packaging_id = fields.Many2one(
        comodel_name='product.packaging',
        string='Packaging',
        states=FIELDS_STATES,
    )
    date = fields.Datetime(
        string='Document Date',
        default=fields.Datetime.now,
        states=FIELDS_STATES,
        copy=False
    )
    date_done = fields.Datetime(
        string='Shipping Date',
        readonly=True,
        copy=False,
    )
    company_id = fields.Many2one(
        comodel_name='res.company',
        string='Company',
        required=True,
        index=True,
        states=FIELDS_STATES,
        default=_default_company_id,
    )
    move_line_ids = fields.One2many(
        comodel_name='stock.move.line',
        compute='_compute_move_line_ids',
        readonly=True,
        oldname='pack_operation_ids'
    )
    package_id = fields.Many2one(
        comodel_name='stock.quant.package',
        string='Pack',
        readonly=True,
        copy=False,
    )
    note = fields.Text()
    weight = fields.Float(compute='_compute_weight',
                          help="The weight is computed when the "
                               "preparation is done.")
    quant_ids = fields.Many2many(
        compute='_compute_quant_ids',
        comodel_name='stock.quant',
        relation='stock_quant_pack_prepare_rel',
        column1='stock_picking_package_preparation_id',
        column2='stock_quant_id',
        string='All Content',
    )

    @api.multi
    @api.depends('package_id')
    def _compute_quant_ids(self):
        for preparation in self:
            package = preparation.package_id
            preparation.quant_ids = package.get_content()

    @api.multi
    @api.depends('package_id',
                 'package_id.quant_ids')
    def _compute_weight(self):
        for preparation in self:
            package = preparation.package_id
            if not package:
                return
            quants = package._get_contained_quants()
            # weight of the products only
            weight = sum(l.product_id.weight * l.quantity for l in quants)
            preparation.weight = weight

    @api.multi
    @api.depends('picking_ids',
                 'picking_ids.move_line_ids')
    def _compute_move_line_ids(self):
        for preparation in self:
            preparation.move_line_ids = preparation.mapped(
                'picking_ids.move_line_ids')

    @api.multi
    def action_done(self):
        if not self.mapped('package_id'):
            raise UserError(
                _('The package has not been generated.')
            )
        for picking in self.picking_ids:
            picking.do_transfer()
        self.write({'state': 'done', 'date_done': fields.Datetime.now()})

    @api.multi
    def action_cancel(self):
        if any(prep.state == 'done' for prep in self):
            raise UserError(
                _('Cannot cancel a done package preparation.')
            )
        package_ids = self.mapped('package_id')
        if package_ids:
            package_ids.unlink()
        self.write({'state': 'cancel'})

    @api.multi
    def action_draft(self):
        if any(prep.state != 'cancel' for prep in self):
            raise UserError(
                _('Only canceled package preparations can be reset to draft.')
            )
        self.write({'state': 'draft'})

    @api.multi
    def action_put_in_pack(self):
        for preparation in self:
            preparation._generate_pack()
        self.write({'state': 'in_pack'})

    @api.multi
    def _prepare_package(self):
        self.ensure_one()
        if not self.picking_ids:
            raise UserError(
                _('No transfer selected for this preparation.')
            )
        location = self.mapped('picking_ids.location_dest_id')
        if len(location) > 1:
            raise UserError(
                _('All the transfers must have the same destination location')
            )
        values = {
            'packaging_id': self.packaging_id.id,
            'location_id': location.id,
        }
        return values

    @api.multi
    def _generate_pack(self):
        self.ensure_one()
        pack_model = self.env['stock.quant.package']
        move_line_model = self.env['stock.move.line']

        if any(picking.state != 'assigned' for picking in self.picking_ids):
            raise UserError(
                _('All the transfers must be "Ready to Transfer".')
            )

        move_lines = move_line_model.browse()
        for picking in self.picking_ids:
            if not picking.move_line_ids:
                picking.action_assign()
            move_lines |= picking.move_line_ids

        for move_line in move_lines:
            move_line.qty_done = move_line.product_qty

        pack = pack_model.create(self._prepare_package())

        move_lines.write({'result_package_id': pack.id})
        self.package_id = pack.id

1	# Copyright 2015 Guewen Baconnier
2	# Copyright 2016 Lorenzo Battistini - Agile Business Group
3	# Copyright 2016 Alessio Gerace - Agile Business Group
4	# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
5
6	from odoo import models, fields, api, _	2✔
7	from odoo.exceptions import Warning as UserError	2✔
8
9
10	class StockPickingPackagePreparation(models.Model):	2✔
11	_name = 'stock.picking.package.preparation'	2✔
12	_description = 'Package Preparation'	2✔
13	_inherit = ['mail.thread']	2✔
14
15	FIELDS_STATES = {'done': [('readonly', True)],	2✔
16	'in_pack': [('readonly', True)],
17	'cancel': [('readonly', True)]}
18
19	def _default_company_id(self):	2✔
20	company_model = self.env['res.company']	2✔
21	return company_model._company_default_get(self._name)	2✔
22
23	name = fields.Char(	2✔
24	related='package_id.name',
25	readonly=True,
26	index=True,
27	store=True,
28	)
29	state = fields.Selection(	2✔
30	selection=[('draft', 'Draft'),
31	('cancel', 'Cancelled'),
32	('in_pack', 'In Pack'),
33	('done', 'Done'),
34	],
35	default='draft',
36	string='State',
37	readonly=True,
38	copy=False,
39	)
40	partner_id = fields.Many2one(	2✔
41	comodel_name='res.partner',
42	string='Partner',
43	required=True,
44	states=FIELDS_STATES,
45	)
46	picking_ids = fields.Many2many(	2✔
47	comodel_name='stock.picking',
48	relation='stock_picking_pack_prepare_rel',
49	column1='stock_picking_package_preparation_id',
50	column2='stock_picking_id',
51	string='Transfers',
52	copy=False,
53	states=FIELDS_STATES,
54	)
55	packaging_id = fields.Many2one(	2✔
56	comodel_name='product.packaging',
57	string='Packaging',
58	states=FIELDS_STATES,
59	)
60	date = fields.Datetime(	2✔
61	string='Document Date',
62	default=fields.Datetime.now,
63	states=FIELDS_STATES,
64	copy=False
65	)
66	date_done = fields.Datetime(	2✔
67	string='Shipping Date',
68	readonly=True,
69	copy=False,
70	)
71	company_id = fields.Many2one(	2✔
72	comodel_name='res.company',
73	string='Company',
74	required=True,
75	index=True,
76	states=FIELDS_STATES,
77	default=_default_company_id,
78	)
79	move_line_ids = fields.One2many(	2✔
80	comodel_name='stock.move.line',
81	compute='_compute_move_line_ids',
82	readonly=True,
83	oldname='pack_operation_ids'
84	)
85	package_id = fields.Many2one(	2✔
86	comodel_name='stock.quant.package',
87	string='Pack',
88	readonly=True,
89	copy=False,
90	)
91	note = fields.Text()	2✔
92	weight = fields.Float(compute='_compute_weight',	2✔
93	help="The weight is computed when the "
94	"preparation is done.")
95	quant_ids = fields.Many2many(	2✔
96	compute='_compute_quant_ids',
97	comodel_name='stock.quant',
98	relation='stock_quant_pack_prepare_rel',
99	column1='stock_picking_package_preparation_id',
100	column2='stock_quant_id',
101	string='All Content',
102	)
103
104	@api.multi	2✔
105	@api.depends('package_id')	2✔
106	def _compute_quant_ids(self):
107	for preparation in self:	×
108	package = preparation.package_id	×
109	preparation.quant_ids = package.get_content()	×
110
111	@api.multi	2✔
112	@api.depends('package_id',	2✔
113	'package_id.quant_ids')
114	def _compute_weight(self):
115	for preparation in self:	2✔
116	package = preparation.package_id	2✔
117	if not package:	2✔
118	return	×
119	quants = package._get_contained_quants()	2✔
120	# weight of the products only
121	weight = sum(l.product_id.weight * l.quantity for l in quants)	2✔
122	preparation.weight = weight	2✔
123
124	@api.multi	2✔
125	@api.depends('picking_ids',	2✔
126	'picking_ids.move_line_ids')
127	def _compute_move_line_ids(self):
128	for preparation in self:	×
129	preparation.move_line_ids = preparation.mapped(	×
130	'picking_ids.move_line_ids')
131
132	@api.multi	2✔
133	def action_done(self):
134	if not self.mapped('package_id'):	2✔
135	raise UserError(	×
136	_('The package has not been generated.')
137	)
138	for picking in self.picking_ids:	2✔
139	picking.do_transfer()	2✔
140	self.write({'state': 'done', 'date_done': fields.Datetime.now()})	2✔
141
142	@api.multi	2✔
143	def action_cancel(self):
144	if any(prep.state == 'done' for prep in self):	×
145	raise UserError(	×
146	_('Cannot cancel a done package preparation.')
147	)
148	package_ids = self.mapped('package_id')	×
149	if package_ids:	×
150	package_ids.unlink()	×
151	self.write({'state': 'cancel'})	×
152
153	@api.multi	2✔
154	def action_draft(self):
155	if any(prep.state != 'cancel' for prep in self):	×
156	raise UserError(	×
157	_('Only canceled package preparations can be reset to draft.')
158	)
159	self.write({'state': 'draft'})	×
160
161	@api.multi	2✔
162	def action_put_in_pack(self):
163	for preparation in self:	2✔
164	preparation._generate_pack()	2✔
165	self.write({'state': 'in_pack'})	2✔
166
167	@api.multi	2✔
168	def _prepare_package(self):
169	self.ensure_one()	2✔
170	if not self.picking_ids:	2✔
171	raise UserError(	×
172	_('No transfer selected for this preparation.')
173	)
174	location = self.mapped('picking_ids.location_dest_id')	2✔
175	if len(location) > 1:	2✔
176	raise UserError(	×
177	_('All the transfers must have the same destination location')
178	)
179	values = {	2✔
180	'packaging_id': self.packaging_id.id,
181	'location_id': location.id,
182	}
183	return values	2✔
184
185	@api.multi	2✔
186	def _generate_pack(self):
187	self.ensure_one()	2✔
188	pack_model = self.env['stock.quant.package']	2✔
189	move_line_model = self.env['stock.move.line']	2✔
190
191	if any(picking.state != 'assigned' for picking in self.picking_ids):	2✔
192	raise UserError(	×
193	_('All the transfers must be "Ready to Transfer".')
194	)
195
196	move_lines = move_line_model.browse()	2✔
197	for picking in self.picking_ids:	2✔
198	if not picking.move_line_ids:	2✔
199	picking.action_assign()	×
200	move_lines \|= picking.move_line_ids	2✔
201
202	for move_line in move_lines:	2✔
203	move_line.qty_done = move_line.product_qty	2✔
204
205	pack = pack_model.create(self._prepare_package())	2✔
206
207	move_lines.write({'result_package_id': pack.id})	2✔
208	self.package_id = pack.id	2✔

OCA / stock-logistics-workflow / 2253

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous