8501

Build # 8501

Build Type

push

jenkins

Committed by GitHub

Commit Message

<a href="https://github.com/apache/carbondata/commit/<a class=hub.com/apache/carbondata/commit/f2910f0473da464cd7edae36897ba2ff65faca7e">f2910f047<a href="https://github.com/apache/carbondata/commit/f2910f0473da464cd7edae36897ba2ff65faca7e">">Merge </a><a class="double-link" href="https://github.com/apache/carbondata/commit/<a class="double-link" href="https://github.com/apache/carbondata/commit/8544ed699424ff6089d28b8e07f582a2f9e25b78">8544ed699</a>">8544ed699</a><a href="https://github.com/apache/carbondata/commit/f2910f0473da464cd7edae36897ba2ff65faca7e"> into 4c692d185">4c692d185</a>

Run Details

61 of 61 new or added lines in 3 files covered. (100.0%)

58740 of 72738 relevant lines covered (80.76%)

1.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.55

/core/src/main/java/org/apache/carbondata/core/readcommitter/LatestFilesReadCommittedScope.java

/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.apache.carbondata.core.readcommitter;

import java.io.IOException;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Objects;

import org.apache.carbondata.common.annotations.InterfaceAudience;
import org.apache.carbondata.common.annotations.InterfaceStability;
import org.apache.carbondata.core.datamap.Segment;
import org.apache.carbondata.core.datastore.filesystem.CarbonFile;
import org.apache.carbondata.core.datastore.impl.FileFactory;
import org.apache.carbondata.core.indexstore.blockletindex.SegmentIndexFileStore;
import org.apache.carbondata.core.mutate.UpdateVO;
import org.apache.carbondata.core.statusmanager.LoadMetadataDetails;
import org.apache.carbondata.core.statusmanager.SegmentRefreshInfo;
import org.apache.carbondata.core.statusmanager.SegmentStatus;
import org.apache.carbondata.core.util.path.CarbonTablePath;

import org.apache.hadoop.conf.Configuration;

/**
 * This is a readCommittedScope for non transactional carbon table
 */
@InterfaceAudience.Internal
@InterfaceStability.Stable
public class LatestFilesReadCommittedScope implements ReadCommittedScope {

  private static final long serialVersionUID = -839970494288861816L;
  private String carbonFilePath;
  private String segmentId;
  private ReadCommittedIndexFileSnapShot readCommittedIndexFileSnapShot;
  private LoadMetadataDetails[] loadMetadataDetails;
  private transient Configuration configuration;

  /**
   * a new constructor of this class
   *
   * @param path      carbon file path
   * @param segmentId segment id
   */
  public LatestFilesReadCommittedScope(String path, String segmentId, Configuration configuration)
      throws IOException {
    this.configuration = configuration;
    Objects.requireNonNull(path);
    this.carbonFilePath = path;
    this.segmentId = segmentId;
    takeCarbonIndexFileSnapShot();
  }

  /**
   * a new constructor with path
   *
   * @param path carbon file path
   */
  public LatestFilesReadCommittedScope(String path, Configuration configuration)
      throws IOException {
    this(path, null, configuration);
  }

  /**
   * a new constructor with carbon index files
   *
   * @param indexFiles carbon index files
   */
  public LatestFilesReadCommittedScope(CarbonFile[] indexFiles, Configuration configuration) {
    this.configuration = configuration;
    takeCarbonIndexFileSnapShot(indexFiles);
  }

  private void prepareLoadMetadata() {
    int loadCount = 0;
    Map<String, List<String>> snapshotMap =
        this.readCommittedIndexFileSnapShot.getSegmentIndexFileMap();
    LoadMetadataDetails[] loadMetadataDetailsArray = new LoadMetadataDetails[snapshotMap.size()];
    String segmentID;
    for (Map.Entry<String, List<String>> entry : snapshotMap.entrySet()) {
      segmentID = entry.getKey();
      LoadMetadataDetails loadMetadataDetails = new LoadMetadataDetails();
      long timeSet;
      try {
        timeSet = Long.parseLong(segmentID);
      } catch (NumberFormatException nu) {
        timeSet = 0;
      }
      loadMetadataDetails.setLoadEndTime(timeSet);
      loadMetadataDetails.setLoadStartTime(timeSet);
      loadMetadataDetails.setSegmentStatus(SegmentStatus.SUCCESS);
      loadMetadataDetails.setLoadName(segmentID);
      loadMetadataDetailsArray[loadCount++] = loadMetadataDetails;
    }
    this.loadMetadataDetails = loadMetadataDetailsArray;
  }

  @Override public LoadMetadataDetails[] getSegmentList() throws IOException {
    try {
      if (loadMetadataDetails == null) {
        takeCarbonIndexFileSnapShot();
      }
      return loadMetadataDetails;

    } catch (IOException ex) {
      throw new IOException("Problem encountered while reading the Table Status file.", ex);
    }
  }

  @Override public Map<String, String> getCommittedIndexFile(Segment segment) throws IOException {
    Map<String, String> indexFileStore = new HashMap<>();
    Map<String, List<String>> snapShot = readCommittedIndexFileSnapShot.getSegmentIndexFileMap();
    String segName;
    if (segment.getSegmentNo() != null) {
      segName = segment.getSegmentNo();
    } else {
      segName = segment.getSegmentFileName();
    }
    List<String> index = snapShot.get(segName);
    if (null == index) {
      index = new LinkedList<>();
    }
    for (String indexPath : index) {
      if (indexPath.endsWith(CarbonTablePath.MERGE_INDEX_FILE_EXT)) {
        indexFileStore.put(indexPath, indexPath.substring(indexPath.lastIndexOf('/') + 1));
      } else {
        indexFileStore.put(indexPath, null);
      }
    }
    return indexFileStore;
  }

  @Override
  public SegmentRefreshInfo getCommittedSegmentRefreshInfo(Segment segment, UpdateVO updateVo)
      throws IOException {
    Map<String, SegmentRefreshInfo> snapShot =
        readCommittedIndexFileSnapShot.getSegmentTimestampUpdaterMap();
    String segName;
    if (segment.getSegmentNo() != null) {
      segName = segment.getSegmentNo();
    } else {
      segName = segment.getSegmentFileName();
    }
    SegmentRefreshInfo segmentRefreshInfo = snapShot.get(segName);
    return segmentRefreshInfo;
  }

  private String getSegmentID(String carbonIndexFileName, String indexFilePath) {
    if (indexFilePath.contains("/Fact/Part0/Segment_")) {
      // This is CarbonFile case where the Index files are present inside the Segment Folder
      // So the Segment has to be extracted from the path not from the CarbonIndex file.
      String segString = indexFilePath.substring(0, indexFilePath.lastIndexOf("/") + 1);
      String segName =
          segString.substring(segString.lastIndexOf("_") + 1, segString.lastIndexOf("/"));
      return segName;
    } else {
      String fileName = carbonIndexFileName;
      String segId = fileName.substring(fileName.lastIndexOf("-") + 1, fileName.lastIndexOf("."));
      return segId;
    }
  }

  @Override public void takeCarbonIndexFileSnapShot() throws IOException {
    // Read the current file Path get the list of indexes from the path.
    CarbonFile file = FileFactory.getCarbonFile(carbonFilePath);

    CarbonFile[] carbonIndexFiles = null;
    if (file.isDirectory()) {
      if (segmentId == null) {
        List<CarbonFile> indexFiles = new ArrayList<>();
        SegmentIndexFileStore.getCarbonIndexFilesRecursively(file, indexFiles);
        carbonIndexFiles = indexFiles.toArray(new CarbonFile[0]);
      } else {
        String segmentPath = CarbonTablePath.getSegmentPath(carbonFilePath, segmentId);
        carbonIndexFiles = SegmentIndexFileStore.getCarbonIndexFiles(segmentPath, configuration);
      }
      if (carbonIndexFiles.length == 0) {
        throw new IOException(
            "No Index files are present in the table location :" + carbonFilePath);
      }
      takeCarbonIndexFileSnapShot(carbonIndexFiles);
    } else {
      throw new IOException("Path is not pointing to directory");
    }
  }

  private void takeCarbonIndexFileSnapShot(CarbonFile[] carbonIndexFiles) {
    Map<String, List<String>> indexFileStore = new HashMap<>();
    Map<String, SegmentRefreshInfo> segmentTimestampUpdaterMap = new HashMap<>();
    for (int i = 0; i < carbonIndexFiles.length; i++) {
      // TODO. Nested File Paths.
      if (carbonIndexFiles[i].getName().endsWith(CarbonTablePath.INDEX_FILE_EXT)
          || carbonIndexFiles[i].getName().endsWith(CarbonTablePath.MERGE_INDEX_FILE_EXT)) {
        // Get Segment Name from the IndexFile.
        String indexFilePath =
            FileFactory.getUpdatedFilePath(carbonIndexFiles[i].getAbsolutePath());
        String segId = getSegmentID(carbonIndexFiles[i].getName(), indexFilePath);
        // TODO. During Partition table handling, place Segment File Name.
        List<String> indexList;
        SegmentRefreshInfo segmentRefreshInfo;
        if (indexFileStore.get(segId) == null) {
          indexList = new ArrayList<>(1);
          segmentRefreshInfo =
              new SegmentRefreshInfo(carbonIndexFiles[i].getLastModifiedTime(), 0);
          segmentTimestampUpdaterMap.put(segId, segmentRefreshInfo);
        } else {
          // Entry is already present.
          indexList = indexFileStore.get(segId);
          segmentRefreshInfo = segmentTimestampUpdaterMap.get(segId);
        }
        indexList.add(indexFilePath);
        if (segmentRefreshInfo.getSegmentUpdatedTimestamp() < carbonIndexFiles[i]
            .getLastModifiedTime()) {
          segmentRefreshInfo
              .setSegmentUpdatedTimestamp(carbonIndexFiles[i].getLastModifiedTime());
        }
        indexFileStore.put(segId, indexList);
        segmentRefreshInfo.setCountOfFileInSegment(indexList.size());
      }
    }
    ReadCommittedIndexFileSnapShot readCommittedIndexFileSnapShot =
        new ReadCommittedIndexFileSnapShot(indexFileStore, segmentTimestampUpdaterMap);
    this.readCommittedIndexFileSnapShot = readCommittedIndexFileSnapShot;
    prepareLoadMetadata();
  }

  public Configuration getConfiguration() {
    return configuration;
  }

  @Override public void setConfiguration(Configuration configuration) {
    this.configuration = configuration;
  }
}

1	/*
2	* Licensed to the Apache Software Foundation (ASF) under one or more
3	* contributor license agreements. See the NOTICE file distributed with
4	* this work for additional information regarding copyright ownership.
5	* The ASF licenses this file to You under the Apache License, Version 2.0
6	* (the "License"); you may not use this file except in compliance with
7	* the License. You may obtain a copy of the License at
8	*
9	* http://www.apache.org/licenses/LICENSE-2.0
10	*
11	* Unless required by applicable law or agreed to in writing, software
12	* distributed under the License is distributed on an "AS IS" BASIS,
13	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14	* See the License for the specific language governing permissions and
15	* limitations under the License.
16	*/
17	package org.apache.carbondata.core.readcommitter;
18
19	import java.io.IOException;
20	import java.util.ArrayList;
21	import java.util.HashMap;
22	import java.util.LinkedList;
23	import java.util.List;
24	import java.util.Map;
25	import java.util.Objects;
26
27	import org.apache.carbondata.common.annotations.InterfaceAudience;
28	import org.apache.carbondata.common.annotations.InterfaceStability;
29	import org.apache.carbondata.core.datamap.Segment;
30	import org.apache.carbondata.core.datastore.filesystem.CarbonFile;
31	import org.apache.carbondata.core.datastore.impl.FileFactory;
32	import org.apache.carbondata.core.indexstore.blockletindex.SegmentIndexFileStore;
33	import org.apache.carbondata.core.mutate.UpdateVO;
34	import org.apache.carbondata.core.statusmanager.LoadMetadataDetails;
35	import org.apache.carbondata.core.statusmanager.SegmentRefreshInfo;
36	import org.apache.carbondata.core.statusmanager.SegmentStatus;
37	import org.apache.carbondata.core.util.path.CarbonTablePath;
38
39	import org.apache.hadoop.conf.Configuration;
40
41	/**
42	* This is a readCommittedScope for non transactional carbon table
43	*/
44	@InterfaceAudience.Internal
45	@InterfaceStability.Stable
46	public class LatestFilesReadCommittedScope implements ReadCommittedScope {
47
48	private static final long serialVersionUID = -839970494288861816L;
49	private String carbonFilePath;
50	private String segmentId;
51	private ReadCommittedIndexFileSnapShot readCommittedIndexFileSnapShot;
52	private LoadMetadataDetails[] loadMetadataDetails;
53	private transient Configuration configuration;
54
55	/**
56	* a new constructor of this class
57	*
58	* @param path carbon file path
59	* @param segmentId segment id
60	*/
61	public LatestFilesReadCommittedScope(String path, String segmentId, Configuration configuration)
62	throws IOException {	1✔
63	this.configuration = configuration;	1✔
64	Objects.requireNonNull(path);	1✔
65	this.carbonFilePath = path;	1✔
66	this.segmentId = segmentId;	1✔
67	takeCarbonIndexFileSnapShot();	1✔
68	}	1✔
69
70	/**
71	* a new constructor with path
72	*
73	* @param path carbon file path
74	*/
75	public LatestFilesReadCommittedScope(String path, Configuration configuration)
76	throws IOException {
77	this(path, null, configuration);	1✔
78	}	1✔
79
80	/**
81	* a new constructor with carbon index files
82	*
83	* @param indexFiles carbon index files
84	*/
85	public LatestFilesReadCommittedScope(CarbonFile[] indexFiles, Configuration configuration) {	×
86	this.configuration = configuration;	×
87	takeCarbonIndexFileSnapShot(indexFiles);	×
88	}	×
89
90	private void prepareLoadMetadata() {
91	int loadCount = 0;	1✔
92	Map<String, List<String>> snapshotMap =	1✔
93	this.readCommittedIndexFileSnapShot.getSegmentIndexFileMap();	1✔
94	LoadMetadataDetails[] loadMetadataDetailsArray = new LoadMetadataDetails[snapshotMap.size()];	1✔
95	String segmentID;
96	for (Map.Entry<String, List<String>> entry : snapshotMap.entrySet()) {	1✔
97	segmentID = entry.getKey();	1✔
98	LoadMetadataDetails loadMetadataDetails = new LoadMetadataDetails();	1✔
99	long timeSet;
100	try {
101	timeSet = Long.parseLong(segmentID);	1✔
102	} catch (NumberFormatException nu) {	1✔
103	timeSet = 0;	1✔
104	}	1✔
105	loadMetadataDetails.setLoadEndTime(timeSet);	1✔
106	loadMetadataDetails.setLoadStartTime(timeSet);	1✔
107	loadMetadataDetails.setSegmentStatus(SegmentStatus.SUCCESS);	1✔
108	loadMetadataDetails.setLoadName(segmentID);	1✔
109	loadMetadataDetailsArray[loadCount++] = loadMetadataDetails;	1✔
110	}	1✔
111	this.loadMetadataDetails = loadMetadataDetailsArray;	1✔
112	}	1✔
113
114	@Override public LoadMetadataDetails[] getSegmentList() throws IOException {
115	try {
116	if (loadMetadataDetails == null) {	1✔
117	takeCarbonIndexFileSnapShot();	×
118	}
119	return loadMetadataDetails;	1✔
120
121	} catch (IOException ex) {	×
122	throw new IOException("Problem encountered while reading the Table Status file.", ex);	×
123	}
124	}
125
126	@Override public Map<String, String> getCommittedIndexFile(Segment segment) throws IOException {
127	Map<String, String> indexFileStore = new HashMap<>();	1✔
128	Map<String, List<String>> snapShot = readCommittedIndexFileSnapShot.getSegmentIndexFileMap();	1✔
129	String segName;
130	if (segment.getSegmentNo() != null) {	1✔
131	segName = segment.getSegmentNo();	1✔
132	} else {
133	segName = segment.getSegmentFileName();	×
134	}
135	List<String> index = snapShot.get(segName);	1✔
136	if (null == index) {	1✔
137	index = new LinkedList<>();	×
138	}
139	for (String indexPath : index) {	1✔
140	if (indexPath.endsWith(CarbonTablePath.MERGE_INDEX_FILE_EXT)) {	1✔
141	indexFileStore.put(indexPath, indexPath.substring(indexPath.lastIndexOf('/') + 1));	1✔
142	} else {
143	indexFileStore.put(indexPath, null);	1✔
144	}
145	}	1✔
146	return indexFileStore;	1✔
147	}
148
149	@Override
150	public SegmentRefreshInfo getCommittedSegmentRefreshInfo(Segment segment, UpdateVO updateVo)
151	throws IOException {
152	Map<String, SegmentRefreshInfo> snapShot =	1✔
153	readCommittedIndexFileSnapShot.getSegmentTimestampUpdaterMap();	1✔
154	String segName;
155	if (segment.getSegmentNo() != null) {	1✔
156	segName = segment.getSegmentNo();	1✔
157	} else {
158	segName = segment.getSegmentFileName();	×
159	}
160	SegmentRefreshInfo segmentRefreshInfo = snapShot.get(segName);	1✔
161	return segmentRefreshInfo;	1✔
162	}
163
164	private String getSegmentID(String carbonIndexFileName, String indexFilePath) {
165	if (indexFilePath.contains("/Fact/Part0/Segment_")) {	1✔
166	// This is CarbonFile case where the Index files are present inside the Segment Folder
167	// So the Segment has to be extracted from the path not from the CarbonIndex file.
168	String segString = indexFilePath.substring(0, indexFilePath.lastIndexOf("/") + 1);	1✔
169	String segName =	1✔
170	segString.substring(segString.lastIndexOf("_") + 1, segString.lastIndexOf("/"));	1✔
171	return segName;	1✔
172	} else {
173	String fileName = carbonIndexFileName;	1✔
174	String segId = fileName.substring(fileName.lastIndexOf("-") + 1, fileName.lastIndexOf("."));	1✔
175	return segId;	1✔
176	}
177	}
178
179	@Override public void takeCarbonIndexFileSnapShot() throws IOException {
180	// Read the current file Path get the list of indexes from the path.
181	CarbonFile file = FileFactory.getCarbonFile(carbonFilePath);	1✔
182
183	CarbonFile[] carbonIndexFiles = null;	1✔
184	if (file.isDirectory()) {	1✔
185	if (segmentId == null) {	1✔
186	List<CarbonFile> indexFiles = new ArrayList<>();	1✔
187	SegmentIndexFileStore.getCarbonIndexFilesRecursively(file, indexFiles);	1✔
188	carbonIndexFiles = indexFiles.toArray(new CarbonFile[0]);	1✔
189	} else {	1✔
190	String segmentPath = CarbonTablePath.getSegmentPath(carbonFilePath, segmentId);	×
191	carbonIndexFiles = SegmentIndexFileStore.getCarbonIndexFiles(segmentPath, configuration);	×
192	}
193	if (carbonIndexFiles.length == 0) {	1✔
194	throw new IOException(	1✔
195	"No Index files are present in the table location :" + carbonFilePath);
196	}
197	takeCarbonIndexFileSnapShot(carbonIndexFiles);	1✔
198	} else {
199	throw new IOException("Path is not pointing to directory");	×
200	}
201	}	1✔
202
203	private void takeCarbonIndexFileSnapShot(CarbonFile[] carbonIndexFiles) {
204	Map<String, List<String>> indexFileStore = new HashMap<>();	1✔
205	Map<String, SegmentRefreshInfo> segmentTimestampUpdaterMap = new HashMap<>();	1✔
206	for (int i = 0; i < carbonIndexFiles.length; i++) {	1✔
207	// TODO. Nested File Paths.
208	if (carbonIndexFiles[i].getName().endsWith(CarbonTablePath.INDEX_FILE_EXT)	1✔
209	\|\| carbonIndexFiles[i].getName().endsWith(CarbonTablePath.MERGE_INDEX_FILE_EXT)) {	1✔
210	// Get Segment Name from the IndexFile.
211	String indexFilePath =	1✔
212	FileFactory.getUpdatedFilePath(carbonIndexFiles[i].getAbsolutePath());	1✔
213	String segId = getSegmentID(carbonIndexFiles[i].getName(), indexFilePath);	1✔
214	// TODO. During Partition table handling, place Segment File Name.
215	List<String> indexList;
216	SegmentRefreshInfo segmentRefreshInfo;
217	if (indexFileStore.get(segId) == null) {	1✔
218	indexList = new ArrayList<>(1);	1✔
219	segmentRefreshInfo =	1✔
220	new SegmentRefreshInfo(carbonIndexFiles[i].getLastModifiedTime(), 0);	1✔
221	segmentTimestampUpdaterMap.put(segId, segmentRefreshInfo);	1✔
222	} else {
223	// Entry is already present.
224	indexList = indexFileStore.get(segId);	1✔
225	segmentRefreshInfo = segmentTimestampUpdaterMap.get(segId);	1✔
226	}
227	indexList.add(indexFilePath);	1✔
228	if (segmentRefreshInfo.getSegmentUpdatedTimestamp() < carbonIndexFiles[i]	1✔
229	.getLastModifiedTime()) {	1✔
230	segmentRefreshInfo	×
231	.setSegmentUpdatedTimestamp(carbonIndexFiles[i].getLastModifiedTime());	×
232	}
233	indexFileStore.put(segId, indexList);	1✔
234	segmentRefreshInfo.setCountOfFileInSegment(indexList.size());	1✔
235	}
236	}
237	ReadCommittedIndexFileSnapShot readCommittedIndexFileSnapShot =	1✔
238	new ReadCommittedIndexFileSnapShot(indexFileStore, segmentTimestampUpdaterMap);
239	this.readCommittedIndexFileSnapShot = readCommittedIndexFileSnapShot;	1✔
240	prepareLoadMetadata();	1✔
241	}	1✔
242
243	public Configuration getConfiguration() {
244	return configuration;	1✔
245	}
246
247	@Override public void setConfiguration(Configuration configuration) {
248	this.configuration = configuration;	×
249	}	×
250	}

apache / carbondata / 8501

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous