3658

pending completion

Build # 3658

Build Type

push

travis-ci

Committed by

sunesimonsen

Commit Message

Drop compatibility with pre-10.10.0 type.diff return values

The diff method used to return { inline: <boolean>, diff: <magicPen> },
but that was changed in e22bdef68 with a backwards compatibility hack
that installed a self-referencing 'diff' property.

I suggest we remove the backwards compatibility in Unexpected 11.

Run Details

1817 of 1906 branches covered (95.33%)

10 of 10 new or added lines in 2 files covered. (100.0%)

3258 of 3318 relevant lines covered (98.19%)

7765.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.48

/lib/workQueue.js

const Promise = require('unexpected-bluebird');

const workQueue = {
  queue: [],
  drain() {
    this.queue.forEach(fn => {
      fn();
    });
    this.queue = [];
  }
};

const scheduler = Promise.setScheduler(fn => {
  workQueue.queue.push(fn);
  scheduler(() => {
    workQueue.drain();
  });
});

Promise.prototype._notifyUnhandledRejection = function() {
  const that = this;
  scheduler(() => {
    if (that._isRejectionUnhandled()) {
      if (workQueue.onUnhandledRejection) {
        // for testing
        workQueue.onUnhandledRejection(that.reason());
      } else {
        throw that.reason();
      }
    }
  });
};

module.exports = workQueue;

1	const Promise = require('unexpected-bluebird');	45✔
2
3	const workQueue = {	45✔
4	queue: [],
5	drain() {
6	this.queue.forEach(fn => {	40,665✔
7	fn();	18,855✔
8	});
9	this.queue = [];	40,665✔
10	}
11	};
12
13	const scheduler = Promise.setScheduler(fn => {	45✔
14	workQueue.queue.push(fn);	18,528✔
15	scheduler(() => {	18,528✔
16	workQueue.drain();	18,528✔
17	});
18	});
19
20	Promise.prototype._notifyUnhandledRejection = function() {	45✔
21	const that = this;	6,261✔
22	scheduler(() => {	6,261✔
23	if (that._isRejectionUnhandled()) {	6,258✔
24	if (workQueue.onUnhandledRejection) {	3!
25	// for testing
26	workQueue.onUnhandledRejection(that.reason());	3✔
27	} else {
28	throw that.reason();	×
29	}
30	}
31	});
32	};
33
34	module.exports = workQueue;	45✔

unexpectedjs / unexpected / 3658

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous