mp911de / lettuce / 134

pending completion

Build # 134

Build Type

Pull #27

travis-ci

Committed by

kichik

Commit Message

Fix channel loss on reconnect
The scenario requires two or more close-by disconnections
1. Connect to Redis
2. Subscribe successfully to a channel
3. Forcibly kill the connection (by taking down Redis for example)
4. Let lettuce reconnect successfully
5. Forcibly kill the connection again right before activate() successfully subscribes
6. Let lettuce reconnect successfully
7. RedisPubSubConnectionImpl.channels is empty and the channel will stay unsubscribed

There doesn't seem to be a reason to clear out channels and patterns.
It is only used for persistence over different connections.
There is no downside to having a channel in that set even if the subscription was not successful.

Pull Request Pull Request #27: Fix channel loss on reconnect

Run Details

3508 of 3643 relevant lines covered (96.29%)

0.96 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.0

/com/lambdaworks/redis/pubsub/RedisPubSubConnectionImpl.java

Build SHA Not Found

The commit SHA "a9ad1fa5c602b8a2a0cd5240bdc86b5002bea538" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

mp911de / lettuce / 134

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous