16941187

Build Type

push

appveyor

Committed by GitHub

Commit Message

<a href="https://github.com/benmosher/eslint-plugin-import/commit/<a class=hub.com/benmosher/eslint-plugin-import/commit/5f40edd77956a05d69f42c8fe24b716c089483a2">5f40edd77<a href="https://github.com/benmosher/eslint-plugin-import/commit/5f40edd77956a05d69f42c8fe24b716c089483a2">">Merge </a><a class="double-link" href="https://github.com/benmosher/eslint-plugin-import/commit/<a class="double-link" href="https://github.com/benmosher/eslint-plugin-import/commit/5a0b30abf2229bddf8ceca5a023c85866a49c75f">5a0b30abf</a>">5a0b30abf</a><a href="https://github.com/benmosher/eslint-plugin-import/commit/5f40edd77956a05d69f42c8fe24b716c089483a2"> into 3b04d5fab">3b04d5fab</a>

Run Details

972 of 1080 branches covered (90.0%)

1 of 1 new or added line in 1 file covered. (100.0%)

1383 of 1466 relevant lines covered (94.34%)

42.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.68

/src/rules/no-cycle.js

/**
 * @fileOverview Ensures that no imported module imports the linted module.
 * @author Ben Mosher
 */

import Exports from '../ExportMap'
import moduleVisitor, { makeOptionsSchema } from 'eslint-module-utils/moduleVisitor'
import docsUrl from '../docsUrl'

// todo: cache cycles / deep relationships for faster repeat evaluation
module.exports = {
  meta: {
    docs: { url: docsUrl('no-cycle') },
    schema: [makeOptionsSchema({
      maxDepth:{
        description: 'maximum dependency depth to traverse',
        type: 'integer',
        minimum: 1,
      },
    })],
  },

  create: function (context) {
    const myPath = context.getFilename()
    if (myPath === '<text>') return {} // can't cycle-check a non-file

    const options = context.options[0] || {}
    const maxDepth = options.maxDepth || Infinity

    function checkSourceValue(sourceNode, importer) {
      const imported = Exports.get(sourceNode.value, context)

      if (imported == null) {
        return  // no-unresolved territory
      }

      if (imported.path === myPath) {
        return  // no-self-import territory
      }

      const untraversed = [{mget: () => imported, route:[]}]
      const traversed = new Set()
      function detectCycle({mget, route}) {
        const m = mget()
        if (m == null) return
        if (traversed.has(m.path)) return
        traversed.add(m.path)

        for (let [path, { getter, source }] of m.imports) {
          if (path === myPath) return true
          if (traversed.has(path)) continue
          if (route.length + 1 < maxDepth) {
            untraversed.push({
              mget: getter,
              route: route.concat(source),
            })
          }
        }
      }

      while (untraversed.length > 0) {
        const next = untraversed.shift() // bfs!
        if (detectCycle(next)) {
          const message = (next.route.length > 0
            ? `Dependency cycle via ${routeString(next.route)}`
            : 'Dependency cycle detected.')
          context.report(importer, message)
          return
        }
      }
    }

    return moduleVisitor(checkSourceValue, context.options[0])
  },
}

function routeString(route) {
  return route.map(s => `${s.value}:${s.loc.start.line}`).join('=>')
}

1	/**
2	* @fileOverview Ensures that no imported module imports the linted module.
3	* @author Ben Mosher
4	*/
5
6	import Exports from '../ExportMap'
7	import moduleVisitor, { makeOptionsSchema } from 'eslint-module-utils/moduleVisitor'
8	import docsUrl from '../docsUrl'
9
10	// todo: cache cycles / deep relationships for faster repeat evaluation
11	module.exports = {	1✔
12	meta: {
13	docs: { url: docsUrl('no-cycle') },
14	schema: [makeOptionsSchema({
15	maxDepth:{
16	description: 'maximum dependency depth to traverse',
17	type: 'integer',
18	minimum: 1,
19	},
20	})],
21	},
22
23	create: function (context) {
24	const myPath = context.getFilename()	24✔
25	if (myPath === '<text>') return {} // can't cycle-check a non-file	24!
26
27	const options = context.options[0] \|\| {}	24✔
28	const maxDepth = options.maxDepth \|\| Infinity	24✔
29
30	function checkSourceValue(sourceNode, importer) {
31	const imported = Exports.get(sourceNode.value, context)	14✔
32
33	if (imported == null) {	14✔
34	return // no-unresolved territory	3✔
35	}
36
37	if (imported.path === myPath) {	11!
38	return // no-self-import territory	×
39	}
40
41	const untraversed = [{mget: () => imported, route:[]}]	11✔
42	const traversed = new Set()	11✔
43	function detectCycle({mget, route}) {
44	const m = mget()	18✔
45	if (m == null) return	18!
46	if (traversed.has(m.path)) return	18!
47	traversed.add(m.path)	18✔
48
49	for (let [path, { getter, source }] of m.imports) {	18✔
50	if (path === myPath) return true	18✔
51	if (traversed.has(path)) continue	8!
52	if (route.length + 1 < maxDepth) {	8✔
53	untraversed.push({	7✔
54	mget: getter,
55	route: route.concat(source),
56	})
57	}
58	}
59	}
60
61	while (untraversed.length > 0) {	11✔
62	const next = untraversed.shift() // bfs!	18✔
63	if (detectCycle(next)) {	18✔
64	const message = (next.route.length > 0	10✔
65	? `Dependency cycle via ${routeString(next.route)}`
66	: 'Dependency cycle detected.')
67	context.report(importer, message)	10✔
68	return	10✔
69	}
70	}
71	}
72
73	return moduleVisitor(checkSourceValue, context.options[0])	24✔
74	},
75	}
76
77	function routeString(route) {
78	return route.map(s => `${s.value}:${s.loc.start.line}`).join('=>')	7✔
79	}

benmosher / eslint-plugin-import / 16941187

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous