1777

pending completion

Build # 1777

Build Type

Pull #654

travis-ci

Committed by

web-flow

Commit Message

:sparkles: PHP 7.1: New sniff to detect short list syntax for symmetric array destructuring

> The shorthand array syntax ([]) may now be used to destructure arrays for assignments (including within foreach), as an alternative to the existing list() syntax, which is still supported.

Refs:
* http://php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring
* https://wiki.php.net/rfc/short_list_syntax
* https://github.com/php/php-src/commit/4f077aee8

Fixes 248

Pull Request Pull Request #654: PHP 7.1: New sniff to detect short list syntax for symmetric array destructuring

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

2938 of 3046 relevant lines covered (96.45%)

31.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/PHPCompatibility/Sniffs/PHP/NewAnonymousClassesSniff.php

<?php
/**
 * \PHPCompatibility\Sniffs\PHP\NewAnonymousClasses.
 *
 * PHP version 7.0
 *
 * @category PHP
 * @package  PHPCompatibility
 * @author   Wim Godden <wim.godden@cu.be>
 */

namespace PHPCompatibility\Sniffs\PHP;

use PHPCompatibility\Sniff;

/**
 * \PHPCompatibility\Sniffs\PHP\NewAnonymousClasses.
 *
 * Anonymous classes are supported in PHP 7.0
 *
 * PHP version 7.0
 *
 * @category PHP
 * @package  PHPCompatibility
 * @author   Wim Godden <wim.godden@cu.be>
 */
class NewAnonymousClassesSniff extends Sniff
{

    /**
     * Tokens which in various PHP versions indicate the `class` keyword.
     *
     * The dedicated anonymous class token is added from the `register()`
     * method if the token is available.
     *
     * @var array
     */
    private $indicators = array(
        T_CLASS => T_CLASS,
    );

    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        if (defined('T_ANON_CLASS')) {
            $this->indicators[T_ANON_CLASS] = T_ANON_CLASS;
        }

        return array(T_NEW);
    }//end register()


    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
     * @param int                   $stackPtr  The position of the current token in the
     *                                         stack passed in $tokens.
     *
     * @return void
     */
    public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        if ($this->supportsBelow('5.6') === false) {
            return;
        }

        $tokens       = $phpcsFile->getTokens();
        $nextNonEmpty = $phpcsFile->findNext(\PHP_CodeSniffer_Tokens::$emptyTokens, $stackPtr + 1, null, true, null, true);
        if ($nextNonEmpty === false || isset($this->indicators[$tokens[$nextNonEmpty]['code']]) === false) {
            return;
        }

        // Still here ? In that case, it is an anonymous class.
        $phpcsFile->addError(
            'Anonymous classes are not supported in PHP 5.6 or earlier',
            $stackPtr,
            'Found'
        );

    }//end process()


}//end class

1	<?php
2	/**
3	* \PHPCompatibility\Sniffs\PHP\NewAnonymousClasses.
4	*
5	* PHP version 7.0
6	*
7	* @category PHP
8	* @package PHPCompatibility
9	* @author Wim Godden <wim.godden@cu.be>
10	*/
11
12	namespace PHPCompatibility\Sniffs\PHP;
13
14	use PHPCompatibility\Sniff;
15
16	/**
17	* \PHPCompatibility\Sniffs\PHP\NewAnonymousClasses.
18	*
19	* Anonymous classes are supported in PHP 7.0
20	*
21	* PHP version 7.0
22	*
23	* @category PHP
24	* @package PHPCompatibility
25	* @author Wim Godden <wim.godden@cu.be>
26	*/
27	class NewAnonymousClassesSniff extends Sniff
28	{
29
30	/**
31	* Tokens which in various PHP versions indicate the `class` keyword.
32	*
33	* The dedicated anonymous class token is added from the `register()`
34	* method if the token is available.
35	*
36	* @var array
37	*/
38	private $indicators = array(
39	T_CLASS => T_CLASS,
40	);
41
42	/**
43	* Returns an array of tokens this test wants to listen for.
44	*
45	* @return array
46	*/
47	public function register()
48	{
49	if (defined('T_ANON_CLASS')) {	16✔
50	$this->indicators[T_ANON_CLASS] = T_ANON_CLASS;	7✔
51	}	5✔
52
53	return array(T_NEW);	16✔
54	}//end register()
55
56
57	/**
58	* Processes this test, when one of its tokens is encountered.
59	*
60	* @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
61	* @param int $stackPtr The position of the current token in the
62	* stack passed in $tokens.
63	*
64	* @return void
65	*/
66	public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
67	{
68	if ($this->supportsBelow('5.6') === false) {	12✔
69	return;	6✔
70	}
71
72	$tokens = $phpcsFile->getTokens();	6✔
73	$nextNonEmpty = $phpcsFile->findNext(\PHP_CodeSniffer_Tokens::$emptyTokens, $stackPtr + 1, null, true, null, true);	6✔
74	if ($nextNonEmpty === false \|\| isset($this->indicators[$tokens[$nextNonEmpty]['code']]) === false) {	6✔
75	return;	6✔
76	}
77
78	// Still here ? In that case, it is an anonymous class.
79	$phpcsFile->addError(	6✔
80	'Anonymous classes are not supported in PHP 5.6 or earlier',	6✔
81	$stackPtr,	6✔
82	'Found'	3✔
83	);	3✔
84
85	}//end process()	6✔
86
87
88	}//end class

PHPCompatibility / PHPCompatibility / 1777

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous