wearefractal / glob-stream / 96

pending completion

Build # 96

Build Type

Pull #33

travis-ci

Committed by

UltCombo

Commit Message

Create Minimatch instances for each negative glob only once

This optimizes use cases such as `['a', 'b', '!b']`, where a new Minimatch instance for `'!b'` would be created for each previous positive glob.

Now the Minimatch instances for negative globs are created beforehand, thus positive globs can use the same negative matcher instances. That is, for `['a', 'b', '!b']` both `'a'` and `'b'` globs will use the same Minimatch instance for `'!b'` instead of instantiating their own.

Also, as far as I can see, `gs.createStream` is internal (no docs or tests), so I took the liberty of adapting it a bit as I needed the complete `opt` object to pass to Minimatch in `gs.create`.

Should also note that, theoretically, this would instantiate Minimatch instances that would never be used when considering leading negative globs (e.g. `['!b', 'b']`), but that is a complete misuse and IIRC Minimatch produces their underlying regex lazily, so this shouldn't be a problem.

Pull Request Pull Request #33: Create Minimatch instances for each negative glob only once

Run Details

66 of 67 relevant lines covered (98.51%)

17.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.51

/index.js

Build SHA Not Found

The commit SHA "2bbe50a1d3a460882618faccb1ad481b9721da23" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

wearefractal / glob-stream / 96

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous