1668

pending completion

Build # 1668

Build Type

Pull #640

travis-ci

Committed by

web-flow

Commit Message

PHP 7.3/NewFunctions: add new `is_countable()` function

Ref:
* https://wiki.php.net/rfc/is-countable
* https://github.com/php/php-src/commit/d0ee2a825

I expect that lots of userland `is_countable()` functions will be/have been added since PHP 7.2 added the "counting non-countable" warning.

This should give people plenty of warning that they'll need to wrap that function within a `if (function_exists() === false ) {}` wrapper.

Pull Request Pull Request #640: PHP 7.3/NewFunctions: add new `is_countable()` function

Run Details

2931 of 3040 relevant lines covered (96.41%)

25.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/PHPCompatibility/Sniffs/PHP/InternalInterfacesSniff.php

<?php
/**
 * \PHPCompatibility\Sniffs\PHP\InternalInterfacesSniff.
 *
 * @category PHP
 * @package  PHPCompatibility
 * @author   Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
 */

namespace PHPCompatibility\Sniffs\PHP;

use PHPCompatibility\Sniff;
use PHPCompatibility\PHPCSHelper;

/**
 * \PHPCompatibility\Sniffs\PHP\InternalInterfacesSniff.
 *
 * @category PHP
 * @package  PHPCompatibility
 * @author   Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
 */
class InternalInterfacesSniff extends Sniff
{

    /**
     * A list of PHP internal interfaces, not intended to be implemented by userland classes.
     *
     * The array lists : the error message to use.
     *
     * @var array(string => string)
     */
    protected $internalInterfaces = array(
        'Traversable'       => 'shouldn\'t be implemented directly, implement the Iterator or IteratorAggregate interface instead.',
        'DateTimeInterface' => 'is intended for type hints only and is not implementable.',
        'Throwable'         => 'cannot be implemented directly, extend the Exception class instead.',
    );


    /**
     * Returns an array of tokens this test wants to listen for.
     *
     * @return array
     */
    public function register()
    {
        // Handle case-insensitivity of interface names.
        $this->internalInterfaces = $this->arrayKeysToLowercase($this->internalInterfaces);

        $targets = array(T_CLASS);

        if (defined('T_ANON_CLASS')) {
            // phpcs:ignore PHPCompatibility.PHP.NewConstants.t_anon_classFound
            $targets[] = T_ANON_CLASS;
        }

        return $targets;

    }//end register()


    /**
     * Processes this test, when one of its tokens is encountered.
     *
     * @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
     * @param int                   $stackPtr  The position of the current token in
     *                                         the stack passed in $tokens.
     *
     * @return void
     */
    public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
    {
        $interfaces = PHPCSHelper::findImplementedInterfaceNames($phpcsFile, $stackPtr);

        if (is_array($interfaces) === false || $interfaces === array()) {
            return;
        }

        foreach ($interfaces as $interface) {
            $interfaceLc = strtolower($interface);
            if (isset($this->internalInterfaces[$interfaceLc]) === true) {
                $error     = 'The interface %s %s';
                $errorCode = $this->stringToErrorCode($interfaceLc).'Found';
                $data      = array(
                    $interface,
                    $this->internalInterfaces[$interfaceLc],
                );

                $phpcsFile->addError($error, $stackPtr, $errorCode, $data);
            }
        }

    }//end process()


}//end class

1	<?php
2	/**
3	* \PHPCompatibility\Sniffs\PHP\InternalInterfacesSniff.
4	*
5	* @category PHP
6	* @package PHPCompatibility
7	* @author Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
8	*/
9
10	namespace PHPCompatibility\Sniffs\PHP;
11
12	use PHPCompatibility\Sniff;
13	use PHPCompatibility\PHPCSHelper;
14
15	/**
16	* \PHPCompatibility\Sniffs\PHP\InternalInterfacesSniff.
17	*
18	* @category PHP
19	* @package PHPCompatibility
20	* @author Juliette Reinders Folmer <phpcompatibility_nospam@adviesenzo.nl>
21	*/
22	class InternalInterfacesSniff extends Sniff
23	{
24
25	/**
26	* A list of PHP internal interfaces, not intended to be implemented by userland classes.
27	*
28	* The array lists : the error message to use.
29	*
30	* @var array(string => string)
31	*/
32	protected $internalInterfaces = array(
33	'Traversable' => 'shouldn\'t be implemented directly, implement the Iterator or IteratorAggregate interface instead.',
34	'DateTimeInterface' => 'is intended for type hints only and is not implementable.',
35	'Throwable' => 'cannot be implemented directly, extend the Exception class instead.',
36	);
37
38
39	/**
40	* Returns an array of tokens this test wants to listen for.
41	*
42	* @return array
43	*/
44	public function register()
45	{
46	// Handle case-insensitivity of interface names.
47	$this->internalInterfaces = $this->arrayKeysToLowercase($this->internalInterfaces);	52✔
48
49	$targets = array(T_CLASS);	52✔
50
51	if (defined('T_ANON_CLASS')) {	52✔
52	// phpcs:ignore PHPCompatibility.PHP.NewConstants.t_anon_classFound
53	$targets[] = T_ANON_CLASS;	13 only PHPCS_VERSION=">=2.0,<3.0" LINT=1 COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" ✔
54	}	13 only PHPCS_VERSION=">=2.0,<3.0" LINT=1 COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" ✔
55
56	return $targets;	52✔
57
58	}//end register()
59
60
61	/**
62	* Processes this test, when one of its tokens is encountered.
63	*
64	* @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
65	* @param int $stackPtr The position of the current token in
66	* the stack passed in $tokens.
67	*
68	* @return void
69	*/
70	public function process(\PHP_CodeSniffer_File $phpcsFile, $stackPtr)
71	{
72	$interfaces = PHPCSHelper::findImplementedInterfaceNames($phpcsFile, $stackPtr);	4✔
73
74	if (is_array($interfaces) === false \|\| $interfaces === array()) {	4✔
75	return;	×
76	}
77
78	foreach ($interfaces as $interface) {	4✔
79	$interfaceLc = strtolower($interface);	4✔
80	if (isset($this->internalInterfaces[$interfaceLc]) === true) {	4✔
81	$error = 'The interface %s %s';	4✔
82	$errorCode = $this->stringToErrorCode($interfaceLc).'Found';	4✔
83	$data = array(
84	$interface,	4✔
85	$this->internalInterfaces[$interfaceLc],	4✔
86	);	2 only PHPCS_VERSION=">=1.5.1,<2.0" COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" and PHPCS_VERSION=">=2.0,<3.0" LINT=1 COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" ✔
87
88	$phpcsFile->addError($error, $stackPtr, $errorCode, $data);	4✔
89	}	2 only PHPCS_VERSION=">=1.5.1,<2.0" COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" and PHPCS_VERSION=">=2.0,<3.0" LINT=1 COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" ✔
90	}	2 only PHPCS_VERSION=">=1.5.1,<2.0" COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" and PHPCS_VERSION=">=2.0,<3.0" LINT=1 COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5" ✔
91
92	}//end process()	4✔
93
94
95	}//end class

PHPCompatibility / PHPCompatibility / 1668

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous