Nordstrom / serverless-artillery / 462

pending completion

Build # 462

Build Type

Pull #103

travis-ci

Committed by

web-flow

Commit Message

fix name bug

shortid can generate a name with an underscore within it ('_').  This character is invalid within the "service" attribute we were placing it into.  a quick, easy fix replaces all underscores with an 'A', this increases the appearance of 'A' but only very slightly increases the very low probability of collisions.

add test ensuring the replacement occurs.

replace some expect with should

fixes #96

Pull Request Pull Request #103: Fix service name bug #96

Run Details

340 of 351 branches covered (96.87%)

Branch coverage included in aggregate %.

462 of 462 new or added lines in 13 files covered. (100.0%)

643 of 643 relevant lines covered (100.0%)

30.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/lib/lambda/taskDef.js

Build SHA Not Found

The commit SHA "ad889896d215d79d74dc11b8afb0dcdf7b8bfea5" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

Nordstrom / serverless-artillery / 462

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous