4010

pending completion

Build # 4010

Build Type

Pull #804

travis-ci

Committed by

web-flow

Commit Message

<a href="https://github.com/se-edu/addressbook-level4/commit/<a class=hub.com/se-edu/addressbook-level4/commit/62b4243fdfaa7562e0e5b9970d7470b3f430d810">62b4243fd<a href="https://github.com/se-edu/addressbook-level4/commit/62b4243fdfaa7562e0e5b9970d7470b3f430d810">&quot;&gt;Revert &amp;quot;UiManager: Delete duplicate code&quot;

This reverts commit </a><a class="double-link" href="https://github.com/se-edu/addressbook-level4/commit/<a class="double-link" href="https://github.com/se-edu/addressbook-level4/commit/963f896329284e73a37141f16ca0b09a6beb77ae">963f89632</a>">963f89632</a><a href="https://github.com/se-edu/addressbook-level4/commit/62b4243fdfaa7562e0e5b9970d7470b3f430d810">.

Pull Request Pull Request #804: Delete Duplicate Code in UiManager

Run Details

1435 of 1560 relevant lines covered (91.99%)

0.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.73

/src/main/java/seedu/address/ui/UiManager.java

package seedu.address.ui;

import java.util.logging.Logger;

import com.google.common.eventbus.Subscribe;

import javafx.application.Platform;
import javafx.scene.control.Alert;
import javafx.scene.control.Alert.AlertType;
import javafx.scene.image.Image;
import javafx.stage.Stage;
import seedu.address.MainApp;
import seedu.address.commons.core.ComponentManager;
import seedu.address.commons.core.Config;
import seedu.address.commons.core.LogsCenter;
import seedu.address.commons.events.storage.DataSavingExceptionEvent;
import seedu.address.commons.util.StringUtil;
import seedu.address.logic.Logic;
import seedu.address.model.UserPrefs;

/**
 * The manager of the UI component.
 */
public class UiManager extends ComponentManager implements Ui {

    public static final String ALERT_DIALOG_PANE_FIELD_ID = "alertDialogPane";

    public static final String FILE_OPS_ERROR_DIALOG_STAGE_TITLE = "File Op Error";
    public static final String FILE_OPS_ERROR_DIALOG_HEADER_MESSAGE = "Could not save data";
    public static final String FILE_OPS_ERROR_DIALOG_CONTENT_MESSAGE = "Could not save data to file";

    private static final Logger logger = LogsCenter.getLogger(UiManager.class);
    private static final String ICON_APPLICATION = "/images/address_book_32.png";

    private Logic logic;
    private Config config;
    private UserPrefs prefs;
    private MainWindow mainWindow;

    public UiManager(Logic logic, Config config, UserPrefs prefs) {
        super();
        this.logic = logic;
        this.config = config;
        this.prefs = prefs;
    }

    @Override
    public void start(Stage primaryStage) {
        logger.info("Starting UI...");
        primaryStage.setTitle(config.getAppTitle());

        //Set the application icon.
        primaryStage.getIcons().add(getImage(ICON_APPLICATION));

        try {
            mainWindow = new MainWindow(primaryStage, config, prefs, logic);
            mainWindow.show(); //This should be called before creating other UI parts
            mainWindow.fillInnerParts();

        } catch (Throwable e) {
            logger.severe(StringUtil.getDetails(e));
            showFatalErrorDialogAndShutdown("Fatal error during initializing", e);
        }
    }

    @Override
    public void stop() {
        prefs.updateLastUsedGuiSetting(mainWindow.getCurrentGuiSetting());
        mainWindow.hide();
        mainWindow.releaseResources();
    }

    private void showFileOperationAlertAndWait(String description, String details, Throwable cause) {
        final String content = details + ":\n" + cause.toString();
        showAlertDialogAndWait(AlertType.ERROR, FILE_OPS_ERROR_DIALOG_STAGE_TITLE, description, content);
    }

    private Image getImage(String imagePath) {
        return new Image(MainApp.class.getResourceAsStream(imagePath));
    }

    void showAlertDialogAndWait(Alert.AlertType type, String title, String headerText, String contentText) {
        showAlertDialogAndWait(mainWindow.getPrimaryStage(), type, title, headerText, contentText);
    }

    /**
     * Shows an alert dialog on {@code owner} with the given parameters.
     * This method only returns after the user has closed the alert dialog.
     */
    private static void showAlertDialogAndWait(Stage owner, AlertType type, String title, String headerText,
                                               String contentText) {
        final Alert alert = new Alert(type);
        alert.getDialogPane().getStylesheets().add("view/DarkTheme.css");
        alert.initOwner(owner);
        alert.setTitle(title);
        alert.setHeaderText(headerText);
        alert.setContentText(contentText);
        alert.getDialogPane().setId(ALERT_DIALOG_PANE_FIELD_ID);
        alert.showAndWait();
    }

    /**
     * Shows an error alert dialog with {@code title} and error message, {@code e},
     * and exits the application after the user has closed the alert dialog.
     */
    private void showFatalErrorDialogAndShutdown(String title, Throwable e) {
        logger.severe(title + " " + e.getMessage() + StringUtil.getDetails(e));
        showAlertDialogAndWait(Alert.AlertType.ERROR, title, e.getMessage(), e.toString());
        Platform.exit();
        System.exit(1);
    }

    //==================== Event Handling Code ===============================================================

    @Subscribe
    private void handleDataSavingExceptionEvent(DataSavingExceptionEvent event) {
        logger.info(LogsCenter.getEventHandlingLogMessage(event));
        showFileOperationAlertAndWait(FILE_OPS_ERROR_DIALOG_HEADER_MESSAGE, FILE_OPS_ERROR_DIALOG_CONTENT_MESSAGE,
                event.exception);
    }
}

1	package seedu.address.ui;
2
3	import java.util.logging.Logger;
4
5	import com.google.common.eventbus.Subscribe;
6
7	import javafx.application.Platform;
8	import javafx.scene.control.Alert;
9	import javafx.scene.control.Alert.AlertType;
10	import javafx.scene.image.Image;
11	import javafx.stage.Stage;
12	import seedu.address.MainApp;
13	import seedu.address.commons.core.ComponentManager;
14	import seedu.address.commons.core.Config;
15	import seedu.address.commons.core.LogsCenter;
16	import seedu.address.commons.events.storage.DataSavingExceptionEvent;
17	import seedu.address.commons.util.StringUtil;
18	import seedu.address.logic.Logic;
19	import seedu.address.model.UserPrefs;
20
21	/**
22	* The manager of the UI component.
23	*/
24	public class UiManager extends ComponentManager implements Ui {
25
26	public static final String ALERT_DIALOG_PANE_FIELD_ID = "alertDialogPane";
27
28	public static final String FILE_OPS_ERROR_DIALOG_STAGE_TITLE = "File Op Error";
29	public static final String FILE_OPS_ERROR_DIALOG_HEADER_MESSAGE = "Could not save data";
30	public static final String FILE_OPS_ERROR_DIALOG_CONTENT_MESSAGE = "Could not save data to file";
31
32	private static final Logger logger = LogsCenter.getLogger(UiManager.class);	1✔
33	private static final String ICON_APPLICATION = "/images/address_book_32.png";
34
35	private Logic logic;
36	private Config config;
37	private UserPrefs prefs;
38	private MainWindow mainWindow;
39
40	public UiManager(Logic logic, Config config, UserPrefs prefs) {
41	super();	1✔
42	this.logic = logic;	1✔
43	this.config = config;	1✔
44	this.prefs = prefs;	1✔
45	}	1✔
46
47	@Override
48	public void start(Stage primaryStage) {
49	logger.info("Starting UI...");	1✔
50	primaryStage.setTitle(config.getAppTitle());	1✔
51
52	//Set the application icon.
53	primaryStage.getIcons().add(getImage(ICON_APPLICATION));	1✔
54
55	try {
56	mainWindow = new MainWindow(primaryStage, config, prefs, logic);	1✔
57	mainWindow.show(); //This should be called before creating other UI parts	1✔
58	mainWindow.fillInnerParts();	1✔
59
60	} catch (Throwable e) {	×
61	logger.severe(StringUtil.getDetails(e));	×
62	showFatalErrorDialogAndShutdown("Fatal error during initializing", e);	×
63	}	1✔
64	}	1✔
65
66	@Override
67	public void stop() {
68	prefs.updateLastUsedGuiSetting(mainWindow.getCurrentGuiSetting());	×
69	mainWindow.hide();	×
70	mainWindow.releaseResources();	×
71	}	×
72
73	private void showFileOperationAlertAndWait(String description, String details, Throwable cause) {
74	final String content = details + ":\n" + cause.toString();	1✔
75	showAlertDialogAndWait(AlertType.ERROR, FILE_OPS_ERROR_DIALOG_STAGE_TITLE, description, content);	1✔
76	}	1✔
77
78	private Image getImage(String imagePath) {
79	return new Image(MainApp.class.getResourceAsStream(imagePath));	1✔
80	}
81
82	void showAlertDialogAndWait(Alert.AlertType type, String title, String headerText, String contentText) {
83	showAlertDialogAndWait(mainWindow.getPrimaryStage(), type, title, headerText, contentText);	1✔
84	}	1✔
85
86	/**
87	* Shows an alert dialog on {@code owner} with the given parameters.
88	* This method only returns after the user has closed the alert dialog.
89	*/
90	private static void showAlertDialogAndWait(Stage owner, AlertType type, String title, String headerText,
91	String contentText) {
92	final Alert alert = new Alert(type);	1✔
93	alert.getDialogPane().getStylesheets().add("view/DarkTheme.css");	1✔
94	alert.initOwner(owner);	1✔
95	alert.setTitle(title);	1✔
96	alert.setHeaderText(headerText);	1✔
97	alert.setContentText(contentText);	1✔
98	alert.getDialogPane().setId(ALERT_DIALOG_PANE_FIELD_ID);	1✔
99	alert.showAndWait();	1✔
100	}	1✔
101
102	/**
103	* Shows an error alert dialog with {@code title} and error message, {@code e},
104	* and exits the application after the user has closed the alert dialog.
105	*/
106	private void showFatalErrorDialogAndShutdown(String title, Throwable e) {
107	logger.severe(title + " " + e.getMessage() + StringUtil.getDetails(e));	×
108	showAlertDialogAndWait(Alert.AlertType.ERROR, title, e.getMessage(), e.toString());	×
109	Platform.exit();	×
110	System.exit(1);	×
111	}	×
112
113	//==================== Event Handling Code ===============================================================
114
115	@Subscribe
116	private void handleDataSavingExceptionEvent(DataSavingExceptionEvent event) {
117	logger.info(LogsCenter.getEventHandlingLogMessage(event));	1✔
118	showFileOperationAlertAndWait(FILE_OPS_ERROR_DIALOG_HEADER_MESSAGE, FILE_OPS_ERROR_DIALOG_CONTENT_MESSAGE,	1✔
119	event.exception);
120	}	1✔
121	}

se-edu / addressbook-level4 / 4010

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous