twitter / CocoaSPDY / 210

pending completion

Build # 210

Build Type

Pull #87

travis-ci

Committed by

kgoodier

Commit Message

Avoid use of CFAbsoluteTime as much as possible.

A helper class SPDYStopwatch is introduced here to abstract common
time management duties from the rest of the code.

Since CFAbsoluteTimeGetCurrent() is affected by clock and timezone
changes, it's use should be avoided. mach_absolute_time() is unaffected
by clock changes, but is susceptible to overflow issues (which can be
worked around) and doesn't increment while the system is asleep (which
cannot be worked around). However, it has more appropriate behavior.

Our use of CFAbsoluteTimeGetCurrent() for the timers is unavoidable,
since Cocoa timers are based on it. This seems like it would present
undesirable behavior for our deferrable and connect timers if the clock
were to change, but there's not much to do about it.

Pull Request Pull Request #87: Avoid use of CFAbsoluteTime as much as possible.

Run Details

31 of 31 new or added lines in 4 files covered. (100.0%)

1543 of 3007 relevant lines covered (51.31%)

24.27 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.98

/SPDY/SPDYStream.m

Build SHA Not Found

The commit SHA "4ec60e4e8b200d75bd61f9de6b63f15de327b3e8" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

twitter / CocoaSPDY / 210

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous