2653

pending completion

Build # 2653

Build Type

Pull #1400

travis-ci

Committed by

web-flow

Commit Message

Fix sycnchronous animation queues

#1376 only fixed the problem when animation segments were enqueued in seperate passes through the event loop.  When two animation segments were enqueued on the same pass through the even loop we were starting both segments because the isRunning state was not being set until nextTick.

This should fix all that. I've updated some of the tests which I believe were written in a non-intuitive manner because of this bug. Instead of really understanding the problem I had just written the tests in a way that made them pass. There's probably a name for this sort of behavior. If not, we should invent a name.

Pull Request Pull Request #1400: Fix sycnchronous animation queues

Run Details

2413 of 3293 branches covered (73.28%)

11 of 11 new or added lines in 1 file covered. (100.0%)

6511 of 7942 relevant lines covered (81.98%)

2031.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

22.0

/lib/switch.js

Build SHA Not Found

The commit SHA "577b29974a80f84314a322276ef675046564468e" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

rwaldron / johnny-five / 2653

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous