FAForever / faftools / 297

pending completion

Build # 297

Build Type

Pull #33

travis-ci

Committed by

web-flow

Commit Message

Return errors with result instead of raising

This adds the `raise_on_errors` parameter to the `parse_mod_info`
function.
This parameter is True by default so that the default behaviour does not
change.
If the parameter is set to False, the function will return both data and
errors.

This is necessary because the marshmallow schema returns errors on some
conditions that do not warrant raising an exception, e.g. when the
mod_info contains an empty string in `url`.

Fixes #31

Pull Request Pull Request #33: parse_mode_info: Return errors with result instead of raising

Run Details

8 of 8 new or added lines in 2 files covered. (100.0%)

617 of 857 relevant lines covered (72.0%)

0.72 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/faf/tools/fa/mods.py

Build SHA Not Found

The commit SHA "8f2a27252417fcd9615bfc18a5db65253e390dd0" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

FAForever / faftools / 297

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous