1083

pending completion

Build # 1083

Build Type

Pull #723

travis-ci

Committed by

Renelvon

Commit Message

Refactor code in connection.py

* Drop unused PeerConnection.responses_received.
* Refactor PeerConnection.create_zmq_socket.
  * Allow it to raise an exception; we are catching it elsewhere.
  * Make it a private function.
* Refactor PeerConnection.send_raw.
  * Make failure cases stand out.
  * Do not compress until ready to send.
* Make failure cases stand out in CryptoPeerConnection.start_handshake.
* Refactor and DRY CryptoPeerConnection.check_port.
  * Prefer ipv6 over ipv4 sockets.
  * Remove hardcoded timeout. Use the instance attribute.
* Shorten CryptoPeerConnection.sign.
* Straighten CryptoPeerConnection.encrypt.
* Refactor CryptoPeerConnection.send.
  * Make failure cases stand out.
  * Guard against encrypt returning False.
* Remove PeerListener.cleanup_context. PeerListener no longer manages
  it own zmq.Context. Purge any references.
* Straighten PeerListener.listen.
* PEP8 fixes proposed by gubatron.

Pull Request Pull Request #723: Refactor code in connection.py

Run Details

633 of 3764 relevant lines covered (16.82%)

0.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

10.14

/node/dht.py

Build SHA Not Found

The commit SHA "a7b6ff74ef7a9235d88e43762ca18ec1e2c18070" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

OpenBazaar / OpenBazaar / 1083

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous