nebula-plugins / gradle-ospackage-plugin / 304

pending completion

Build # 304

Build Type

Pull #254

travis-ci

Committed by

web-flow

Commit Message

Avoid scriptlet generation; special-case %pretrans.

Currently, scriptlets are generated for all stages regardless of whether
they do anything. This is best avoided.

Additionally, the %pretrans scriptlet is being treated the same as any
other type of scriptlet. This is a bad idea, as there are conditions
where a shell might not be present to run the %pretrans scriptlet.
Moreover, it's recommended in the Fedora Packaging Guidelines[1] that if
a %pretrans scriptlet is required, it MUST be written in Lua. This means
it makes no sense to include the preamble added to the scriptlet by
scriptWithUtils.

[1] https://fedoraproject.org/wiki/Packaging:Scriptlets#The_.25pretrans_Scriptlet

Pull Request Pull Request #254: Avoid scriptlet generation; special-case %pretrans.

Run Details

12 of 12 new or added lines in 1 file covered. (100.0%)

920 of 1053 relevant lines covered (87.37%)

0.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.9

/src/main/groovy/com/netflix/gradle/plugins/rpm/RpmCopyAction.groovy

Build SHA Not Found

The commit SHA "88a8cfd87ee5d8ce3e63f6ab6c0e176dcfeb45c1" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

nebula-plugins / gradle-ospackage-plugin / 304

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous