mgaitan / waliki / 357

Committed 7 Aug 2017 - 8:18 coverage: 74.969% (-0.03%) from 75.0%

Build # 357

Build Type

Pull #147

travis-ci

Committed by

web-flow

Commit Message

Consistent handling of executable paths for external tools.

Pull Request Pull Request #147: Consistent handling of executable paths for external tools.

Run Details

8 of 10 new or added lines in 4 files covered. (80.0%)

2 existing lines in 1 file now uncovered.

1216 of 1622 relevant lines covered (74.97%)

6.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

/waliki/pdf/views.py

import tempfile
from sh import Command
from django.shortcuts import get_object_or_404
from waliki.models import Page
from waliki.utils import send_file
from waliki.settings import WALIKI_PDF_INCLUDE_TITLE
from waliki.settings import WALIKI_PDF_RST2PDF_BIN
from waliki.acl import permission_required

rst2pdf = Command(WALIKI_PDF_RST2PDF_BIN).bake(_tty_out=False)


@permission_required('view_page')
def pdf(request, slug):
    page = get_object_or_404(Page, slug=slug)

    with tempfile.NamedTemporaryFile(suffix='.pdf') as output:
        outfile = output.name
    if WALIKI_PDF_INCLUDE_TITLE:
        line = "/" * len(page.title)
        title = "%s\n%s\n%s\n\n" % (line, page.title, line)
        with tempfile.NamedTemporaryFile(suffix='.rst', mode="w", delete=False) as infile:
            infile.file.write(title + page.raw)
            infile = infile.name
    else:
        infile = page.abspath
    rst2pdf(infile, o=outfile)
    filename = page.title.replace('/', '-').replace('..', '-')
    return send_file(outfile, filename="%s.pdf" % filename)

1	import tempfile	!
NEW 2	from sh import Command	!
3	from django.shortcuts import get_object_or_404	!
4	from waliki.models import Page	!
5	from waliki.utils import send_file	!
6	from waliki.settings import WALIKI_PDF_INCLUDE_TITLE	!
7	from waliki.settings import WALIKI_PDF_RST2PDF_BIN	!
8	from waliki.acl import permission_required	!
9
NEW 10	rst2pdf = Command(WALIKI_PDF_RST2PDF_BIN).bake(_tty_out=False)	!
11
12
13	@permission_required('view_page')	!
14	def pdf(request, slug):
15	page = get_object_or_404(Page, slug=slug)	!
16
17	with tempfile.NamedTemporaryFile(suffix='.pdf') as output:	!
18	outfile = output.name	!
19	if WALIKI_PDF_INCLUDE_TITLE:	!
20	line = "/" * len(page.title)	!
21	title = "%s\n%s\n%s\n\n" % (line, page.title, line)	!
22	with tempfile.NamedTemporaryFile(suffix='.rst', mode="w", delete=False) as infile:	!
23	infile.file.write(title + page.raw)	!
24	infile = infile.name	!
25	else:
26	infile = page.abspath	!
27	rst2pdf(infile, o=outfile)	!
28	filename = page.title.replace('/', '-').replace('..', '-')	!
29	return send_file(outfile, filename="%s.pdf" % filename)	!

mgaitan / waliki / 357

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous