TryGhost / Ghost-CLI / 668

668

Pull #274

travis-ci

web-flow 
🐷  Improve config error logs and messages

refs #216

This PR changes the `Config.exists()` method in a way that rather than simply returning false, we're catching the error and return a `ConfigError` object that includes the received error object from `fs.readJsonSync()` as a message.

There are two places, where `Config.exists()` is being called and was expecting a boolean `false` to determine if the config is valid. But this can mean, that the config either doesn't exist or has a syntax error. It remained a secret to the user.

I changed this to check for an `options` property (I'm not very happy with the wording of this, but the CLI uses its own errors and not Ignition and I didn't want to change this within this PR), which than has the `message` property that includes a better error message which we then can log for the user.

e. g.

```
A ConfigError occured.

Error detected in the production configuration.

Message: The config.production.json file is missing or not valid JSON
Context: Error: /Users/aileennowak/Code/cli-installs/cli_3/config.production.json: ENOENT: no such file or directory, open '/Users/aileennowak/Code/cli-installs/cli_3/config.production.json'

Debug Information:
    Node Version: v6.11.0
    Ghost-CLI Version: 1.0.0-beta.3
    Environment: production
    Command: 'ghost start'
```
Pull Request #274: 🐷 Improve config error logs and messages

139 of 318 branches covered (43.71%)

13 of 13 new or added lines in 3 files covered. (100.0%)

366 of 637 relevant lines covered (57.46%)

1.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

25.0
/lib/errors.js


Build SHA Not Found

The commit SHA "fbef558cdc81a8bed1d2754e7c523ef64cab8dbb" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.