reactjs / react-modal / 428

pending completion

Build # 428

Build Type

Pull #441

travis-ci

Committed by

web-flow

Commit Message

[fixed] improvements on setAppElement...

There was some pitfalls on how `setAppElement` work.

If your <script /> was in <head />, there was a change that it tries
to use `document.body` that is not yet ready.

Another one was using an selector string that does not find any
elements, causing it to try to perform all call on `null`.

This patch can also help if you want to do server-side rendering,
but this was not tested and, perhaps, it's better to use this function
correctly.

Pull Request Pull Request #441: [fixed] improvements on setAppElement...

Run Details

168 of 283 branches covered (59.36%)

18 of 18 new or added lines in 2 files covered. (100.0%)

301 of 352 relevant lines covered (85.51%)

39.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.31

/src/components/Modal.js

Build SHA Not Found

The commit SHA "c688b6473d2b8d4f7025becb8e1a6c9c0edcd3ae" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

reactjs / react-modal / 428

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous