1351

pending completion

Build # 1351

Build Type

Pull #493

travis-ci

Committed by

web-flow

Commit Message

[FIXED] Authorization Timeout and TLS

When TLS and authorization is enabled, the authorization timeout can
fire during the TLS handshake, causing the server to write the
authorization timeout error string into the client socket, injecting
what becomes bad data into the TLS handshake. This creates misleading
errors on the client such as tls: oversized record received with length
21024.

This moves the authorization timeout scheduling to after the TLS
handshake to avoid the race. This should be safe since TLS has its own
handshake timeout. Added a unit test that fails with the old behavior
and passes with the new. LMK if you can think of a better way to test
this.

Fixes #432

Pull Request Pull Request #493: [FIXED] Authorization Timeout and TLS

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

4915 of 5409 relevant lines covered (90.87%)

2849.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.62

/server/route.go

Build SHA Not Found

The commit SHA "1e01cc7f03747dd771eb618acde1e0dd28f754d3" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

nats-io / gnatsd / 1351

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous