6933

pending completion

Build # 6933

Build Type

push

travis-ci

Committed by

paulirish

Commit Message

<a href="https://github.com/GoogleChrome/lighthouse/commit/<a class=hub.com/GoogleChrome/lighthouse/commit/<a class="double-link" href="https://git"><a class=hub.com/GoogleChrome/lighthouse/commit/<a class="double-link" href="https://git"><a class=hub.com/GoogleChrome/lighthouse/commit/<a class="double-link" href="https://git"><a class=hub.com/GoogleChrome/lighthouse/commit/6d5f655408b2df4aa73f5a7ef383d24de9aeaf38">6d5f65540">&lt;a href=&quot;https://github.com/GoogleChrome/lighthouse/commit/</a><a class="double-link" href="https://github.com/GoogleChrome/lighthouse/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/GoogleChrome/lighthouse/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/GoogleChrome/lighthouse/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/GoogleChrome/lighthouse/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/GoogleChrome/lighthouse/commit/6d5f655408b2df4aa73f5a7ef383d24de9aeaf38">6d5f65540</a><a href="https://github.com/GoogleChrome/lighthouse/commit/6d5f655408b2df4aa73f5a7ef383d24de9aeaf38">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/GoogleChrome/lighthouse/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/GoogleChrome/lighthouse/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/GoogleChrome/lighthouse/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/GoogleChrome/lighthouse/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/GoogleChrome/lighthouse/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/GoogleChrome/lighthouse/commit/6d5f655408b2df4aa73f5a7ef383d24de9aeaf38&quot;&gt;6d5f65540&lt;/a&gt;&lt;a href=&quot;https://github.com/GoogleChrome/lighthouse/commit/6d5f655408b2df4aa73f5a7ef383d24de9aeaf38&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/GoogleChrome/lighthouse/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot... (continued)

Run Details

19 of 19 new or added lines in 10 files covered. (100.0%)

3873 of 4783 relevant lines covered (80.97%)

702.28 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.25

/lighthouse-core/audits/byte-efficiency/byte-efficiency-audit.js

/**
 * @license
 * Copyright 2017 Google Inc. All rights reserved.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
'use strict';

const Audit = require('../audit');
const Formatter = require('../../report/formatter');

const KB_IN_BYTES = 1024;
const WASTEFUL_THRESHOLD_IN_BYTES = 20 * KB_IN_BYTES;

/**
 * @overview Used as the base for all byte efficiency audits. Computes total bytes
 *    and estimated time saved. Subclass and override `audit_` to return results.
 */
class UnusedBytes extends Audit {
  /**
   * @param {number} bytes
   * @return {string}
   */
  static bytesToKbString(bytes) {
    return Math.round(bytes / KB_IN_BYTES).toLocaleString() + ' KB';
  }

  /**
   * @param {number} bytes
   * @param {number} percent
   * @return {string}
   */
  static toSavingsString(bytes = 0, percent = 0) {
    const kbDisplay = this.bytesToKbString(bytes);
    const percentDisplay = Math.round(percent).toLocaleString() + '%';
    return `${kbDisplay} _${percentDisplay}_`;
  }

  /**
   * @param {number} bytes
   * @param {number} networkThroughput measured in bytes/second
   * @return {string}
   */
  static bytesToMsString(bytes, networkThroughput) {
    return (Math.round(bytes / networkThroughput * 100) * 10).toLocaleString() + 'ms';
  }

  /**
   * @param {!Artifacts} artifacts
   * @return {!Promise<!AuditResult>}
   */
  static audit(artifacts) {
    const devtoolsLogs = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];
    return artifacts.requestNetworkRecords(devtoolsLogs).then(networkRecords => {
      return artifacts.requestNetworkThroughput(networkRecords).then(networkThroughput =>
        Promise.resolve(this.audit_(artifacts, networkRecords)).then(result =>
          this.createAuditResult(result, networkThroughput)
        )
      );
    });
  }

  /**
   * @param {!{debugString: string=, passes: boolean=, tableHeadings: !Object,
   *    results: !Array<!Object>}} result
   * @param {number} networkThroughput
   * @return {!AuditResult}
   */
  static createAuditResult(result, networkThroughput) {
    const debugString = result.debugString;
    const results = result.results
        .map(item => {
          item.wastedKb = this.bytesToKbString(item.wastedBytes);
          item.wastedMs = this.bytesToMsString(item.wastedBytes, networkThroughput);
          item.totalKb = this.bytesToKbString(item.totalBytes);
          item.totalMs = this.bytesToMsString(item.totalBytes, networkThroughput);
          item.potentialSavings = this.toSavingsString(item.wastedBytes, item.wastedPercent);
          return item;
        })
        .sort((itemA, itemB) => itemB.wastedBytes - itemA.wastedBytes);

    const wastedBytes = results.reduce((sum, item) => sum + item.wastedBytes, 0);

    let displayValue = result.displayValue || '';
    if (typeof result.displayValue === 'undefined' && wastedBytes) {
      const wastedKbDisplay = this.bytesToKbString(wastedBytes);
      const wastedMsDisplay = this.bytesToMsString(wastedBytes, networkThroughput);
      displayValue = `Potential savings of ${wastedKbDisplay} (~${wastedMsDisplay})`;
    }

    return {
      debugString,
      displayValue,
      rawValue: typeof result.passes === 'undefined' ?
          wastedBytes < WASTEFUL_THRESHOLD_IN_BYTES :
          !!result.passes,
      extendedInfo: {
        formatter: Formatter.SUPPORTED_FORMATS.TABLE,
        value: {results, tableHeadings: result.tableHeadings}
      }
    };
  }

  /**
   * @param {!Artifacts} artifacts
   * @return {{results: !Array<Object>, tableHeadings: Object,
   *     passes: boolean=, debugString: string=}}
   */
  static audit_() {
    throw new Error('audit_ unimplemented');
  }
}

module.exports = UnusedBytes;

1	/**
2	* @license
3	* Copyright 2017 Google Inc. All rights reserved.
4	*
5	* Licensed under the Apache License, Version 2.0 (the "License");
6	* you may not use this file except in compliance with the License.
7	* You may obtain a copy of the License at
8	*
9	* http://www.apache.org/licenses/LICENSE-2.0
10	*
11	* Unless required by applicable law or agreed to in writing, software
12	* distributed under the License is distributed on an "AS IS" BASIS,
13	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14	* See the License for the specific language governing permissions and
15	* limitations under the License.
16	*/
17	'use strict';
18
19	const Audit = require('../audit');	2✔
20	const Formatter = require('../../report/formatter');	2✔
21
22	const KB_IN_BYTES = 1024;	2✔
23	const WASTEFUL_THRESHOLD_IN_BYTES = 20 * KB_IN_BYTES;	2✔
24
25	/**
26	* @overview Used as the base for all byte efficiency audits. Computes total bytes
27	* and estimated time saved. Subclass and override `audit_` to return results.
28	*/
29	class UnusedBytes extends Audit {
30	/**
31	* @param {number} bytes
32	* @return {string}
33	*/
34	static bytesToKbString(bytes) {
35	return Math.round(bytes / KB_IN_BYTES).toLocaleString() + ' KB';	400✔
36	}
37
38	/**
39	* @param {number} bytes
40	* @param {number} percent
41	* @return {string}
42	*/
43	static toSavingsString(bytes = 0, percent = 0) {
44	const kbDisplay = this.bytesToKbString(bytes);	74✔
45	const percentDisplay = Math.round(percent).toLocaleString() + '%';	74✔
46	return `${kbDisplay} _${percentDisplay}_`;	74✔
47	}
48
49	/**
50	* @param {number} bytes
51	* @param {number} networkThroughput measured in bytes/second
52	* @return {string}
53	*/
54	static bytesToMsString(bytes, networkThroughput) {
55	return (Math.round(bytes / networkThroughput * 100) * 10).toLocaleString() + 'ms';	92✔
56	}
57
58	/**
59	* @param {!Artifacts} artifacts
60	* @return {!Promise<!AuditResult>}
61	*/
62	static audit(artifacts) {
63	const devtoolsLogs = artifacts.devtoolsLogs[Audit.DEFAULT_PASS];	×
64	return artifacts.requestNetworkRecords(devtoolsLogs).then(networkRecords => {	×
65	return artifacts.requestNetworkThroughput(networkRecords).then(networkThroughput =>	×
66	Promise.resolve(this.audit_(artifacts, networkRecords)).then(result =>	×
67	this.createAuditResult(result, networkThroughput)	×
68	)
69	);
70	});
71	}
72
73	/**
74	* @param {!{debugString: string=, passes: boolean=, tableHeadings: !Object,
75	* results: !Array<!Object>}} result
76	* @param {number} networkThroughput
77	* @return {!AuditResult}
78	*/
79	static createAuditResult(result, networkThroughput) {
80	const debugString = result.debugString;	16✔
81	const results = result.results	16✔
82	.map(item => {
83	item.wastedKb = this.bytesToKbString(item.wastedBytes);	22✔
84	item.wastedMs = this.bytesToMsString(item.wastedBytes, networkThroughput);	22✔
85	item.totalKb = this.bytesToKbString(item.totalBytes);	22✔
86	item.totalMs = this.bytesToMsString(item.totalBytes, networkThroughput);	22✔
87	item.potentialSavings = this.toSavingsString(item.wastedBytes, item.wastedPercent);	22✔
88	return item;	22✔
89	})
90	.sort((itemA, itemB) => itemB.wastedBytes - itemA.wastedBytes);	12✔
91
92	const wastedBytes = results.reduce((sum, item) => sum + item.wastedBytes, 0);	22✔
93
94	let displayValue = result.displayValue \|\| '';	16✔
95	if (typeof result.displayValue === 'undefined' && wastedBytes) {	16✔
96	const wastedKbDisplay = this.bytesToKbString(wastedBytes);	14✔
97	const wastedMsDisplay = this.bytesToMsString(wastedBytes, networkThroughput);	14✔
98	displayValue = `Potential savings of ${wastedKbDisplay} (~${wastedMsDisplay})`;	14✔
99	}
100
101	return {	16✔
102	debugString,
103	displayValue,
104	rawValue: typeof result.passes === 'undefined' ?
105	wastedBytes < WASTEFUL_THRESHOLD_IN_BYTES :
106	!!result.passes,
107	extendedInfo: {
108	formatter: Formatter.SUPPORTED_FORMATS.TABLE,
109	value: {results, tableHeadings: result.tableHeadings}
110	}
111	};
112	}
113
114	/**
115	* @param {!Artifacts} artifacts
116	* @return {{results: !Array<Object>, tableHeadings: Object,
117	* passes: boolean=, debugString: string=}}
118	*/
119	static audit_() {
120	throw new Error('audit_ unimplemented');	×
121	}
122	}
123
124	module.exports = UnusedBytes;	2✔

GoogleChrome / lighthouse / 6933

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous