1018

pending completion

Build # 1018

Build Type

Pull #621

travis-ci

Committed by

web-flow

Commit Message

Handling Oauth server internal errors.

In situation when your OAuth server dies, the web server often gives you
default error 500 page. This page has text/html type, but current
behavior - is to try to parse in anyway.

The problem is: without handling the 500 code on non-json page, you will
get the type error on line 529, which can be hard to debug. So even if
this fix will not enough and you reject it, please at least make some
notice in documentation about handling such errors.

While you auth with Googe, Facebook, etc providers all is usually ok -
they test what they write. But there are lots of sites who provides the
oauth with awful and unstable realisation.

Pull Request Pull Request #621: Handling Oauth server internal errors.

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

332 of 336 relevant lines covered (98.81%)

29.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

97.5

/src/Provider/AbstractProvider.php

Build SHA Not Found

The commit SHA "53c94d37ada7cd379ab707c78811ca1be482e191" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

thephpleague / oauth2-client / 1018

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous