3237

pending completion

Build # 3237

Build Type

Pull #1335

travis-ci

Committed by

web-flow

Commit Message

Fail tests that finish with pending assertions

`t.throws()` and `t.notThrows()` can be called with an observable or
promise. This commit forces users to wait for the assertion to complete
before finishing the test. Usually this means the test has to be written
like:

```js
test(async t => {
  await t.throws(Promise.reject(new Error()))
})
```

Or for callback tests:

```js
test.cb(t => {
  t.throws(Promise.reject(new Error())).then(t.end)
})
```

This simplifies internal logic and helps discourage code like in #1327.
Anecdotally users are surprised by the previous behavior where a
synchronous test worked with an asynchronous assertion
(https://github.com/avajs/ava/issues/1327#issuecomment-291122432).

Fixes #1327.

Pull Request Pull Request #1335: Fail tests that finish with pending assertions

Run Details

1037 of 1115 branches covered (93.0%)

15 of 15 new or added lines in 1 file covered. (100.0%)

2106 of 2176 relevant lines covered (96.78%)

578.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.71

/lib/cli.js

Build SHA Not Found

The commit SHA "c1ea2d65d5618b453ee1111c1868feb33321afd7" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

avajs / ava / 3237

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous