apiaryio / dredd / 3167

push

travis-ci

fix: Test and fix the Content-Length calculation behavior

Dredd should prevent user errors by always calculating the Content-Length
header value. If it differs from what user provided, it should warn
and use the calculated value anyway. There is no reason for user to
override the calculated value and having the value out of sync with
body size just brings all sorts of strange behavior.

Also, Dredd needs to calculate the value before the 'request' library
does it, because

1) it needs to ensure the behavior described above,
2) setting Content-Length to zero if there's no body seems to be like
   a good thing to do (and 'request' doesn't do it),
3) the added header needs to be propagated back to the transaction
   object so Dredd is transparent about what was actually sent to the
   server under test

Close https://github.com/apiaryio/dredd/issues/751
Close https://github.com/apiaryio/dredd/issues/408

20 of 20 new or added lines in 1 file covered. (100.0%)

1911 of 2035 relevant lines covered (93.91%)

126.24 hits per line