microservices-demo / orders / #38

pending completion

Build # #38

Build Type

Pull #44

true

Committed by

web-flow

Commit Message

<a href="https://github.com/microservices-demo/orders/commit/<a class=hub.com/microservices-demo/orders/commit/570635e8d5a12b17b32939fd086f4abede05ebaa">570635e8d<a href="https://github.com/microservices-demo/orders/commit/570635e8d5a12b17b32939fd086f4abede05ebaa">">Merge </a><a class="double-link" href="https://github.com/microservices-demo/orders/commit/<a class="double-link" href="https://github.com/microservices-demo/orders/commit/495419991319411bc0a1eeffe0a4afc06eba6587">495419991</a>">495419991</a><a href="https://github.com/microservices-demo/orders/commit/570635e8d5a12b17b32939fd086f4abede05ebaa"> into b3a03ad11">b3a03ad11</a>

Pull Request Pull Request #44: Rationalise prometheus to produce RED metrics

Run Details

29 of 29 new or added lines in 3 files covered. (100.0%)

153 of 508 relevant lines covered (30.12%)

0.3 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/main/java/works/weave/socks/orders/middleware/HTTPMonitoringInterceptor.java

package works.weave.socks.orders.middleware;

import io.prometheus.client.Histogram;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.web.servlet.HandlerInterceptor;
import org.springframework.web.servlet.ModelAndView;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

public class HTTPMonitoringInterceptor implements HandlerInterceptor {
    static final Histogram requestLatency = Histogram.build()
            .name("request_duration_seconds")
            .help("Request duration in seconds.")
            .labelNames("service", "method", "route", "status_code")
            .register();

    private static final String startTimeKey = "startTime";

    @Value("${spring.application.name:orders}")
    private String serviceName;

    @Override
    public boolean preHandle(HttpServletRequest httpServletRequest, HttpServletResponse
            httpServletResponse, Object o) throws Exception {
        httpServletRequest.setAttribute(startTimeKey, System.nanoTime());
        return true;
    }

    @Override
    public void postHandle(HttpServletRequest httpServletRequest, HttpServletResponse
            httpServletResponse, Object o, ModelAndView modelAndView) throws Exception {
        long start = (long) httpServletRequest.getAttribute(startTimeKey);
        long elapsed = System.nanoTime() - start;
        double seconds = (double) elapsed / 1000000000.0;
        requestLatency.labels(
                serviceName,
                httpServletRequest.getMethod(),
                httpServletRequest.getServletPath(),
                Integer.toString(httpServletResponse.getStatus())
        ).observe(seconds);
    }

    @Override
    public void afterCompletion(HttpServletRequest httpServletRequest, HttpServletResponse
            httpServletResponse, Object o, Exception e) throws Exception {
    }
}

1	package works.weave.socks.orders.middleware;
2
3	import io.prometheus.client.Histogram;
4	import org.springframework.beans.factory.annotation.Value;
5	import org.springframework.web.servlet.HandlerInterceptor;
6	import org.springframework.web.servlet.ModelAndView;
7
8	import javax.servlet.http.HttpServletRequest;
9	import javax.servlet.http.HttpServletResponse;
10
11	public class HTTPMonitoringInterceptor implements HandlerInterceptor {	×
12	static final Histogram requestLatency = Histogram.build()	×
13	.name("request_duration_seconds")	×
14	.help("Request duration in seconds.")	×
15	.labelNames("service", "method", "route", "status_code")	×
16	.register();	×
17
18	private static final String startTimeKey = "startTime";
19
20	@Value("${spring.application.name:orders}")
21	private String serviceName;
22
23	@Override
24	public boolean preHandle(HttpServletRequest httpServletRequest, HttpServletResponse
25	httpServletResponse, Object o) throws Exception {
26	httpServletRequest.setAttribute(startTimeKey, System.nanoTime());	×
27	return true;	×
28	}
29
30	@Override
31	public void postHandle(HttpServletRequest httpServletRequest, HttpServletResponse
32	httpServletResponse, Object o, ModelAndView modelAndView) throws Exception {
33	long start = (long) httpServletRequest.getAttribute(startTimeKey);	×
34	long elapsed = System.nanoTime() - start;	×
35	double seconds = (double) elapsed / 1000000000.0;	×
36	requestLatency.labels(	×
37	serviceName,
38	httpServletRequest.getMethod(),	×
39	httpServletRequest.getServletPath(),	×
40	Integer.toString(httpServletResponse.getStatus())	×
41	).observe(seconds);	×
42	}	×
43
44	@Override
45	public void afterCompletion(HttpServletRequest httpServletRequest, HttpServletResponse
46	httpServletResponse, Object o, Exception e) throws Exception {
47	}	×
48	}

microservices-demo / orders / #38

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous