1179

pending completion

Build # 1179

Build Type

push

travis-ci

Committed by

bdarnell

Commit Message

Fix a memory leak and test timeout in websockets.

In some cases (primarily when prepare() is asynchronous), an
HTTP1ServerConnection could be left waiting forever for a connection
to finish when that connection has been detached and handed off to a
WebSocketHandler.  This would manifest as a leak and a timeout in
tests as the HTTPServer waited for all its existing connections to
finish.

Also fix a bug in the test tearDown method that would actually
wait forever for connections to finish instead of timing out.

Closes #1133.

Run Details

68977 of 80739 relevant lines covered (85.43%)

1.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.27

/home/travis/virtualenv/pypy-2.3.1/site-packages/tornado-4.1.dev1-py2.7.egg/tornado/testing.py

Source Not Available

The file "/home/travis/virtualenv/pypy-2.3.1/site-packages/tornado-4.1.dev1-py2.7.egg/tornado/testing.py" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

tornadoweb / tornado / 1179

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous