3082

pending completion

Build # 3082

Build Type

Pull #585

travis-ci

Committed by

web-flow

Commit Message

Fix flaky test TestInboundConnection (#588)

TestInboundConnection verifies that the InboundConnection returns the
right connection. However when the test was run with a relay, there was
a race that could cause the test to fail.

We have a server channel and a relay, and the test called the server
through the relay, so we had:
server --C1--> relay --C?--> server

The relay had a race between whether it would use the incoming
connection from the server to send the call back, or creating a new
connection. When the connection was reused, the test passed since the
relay responds with the host:port on inbound connections. However when
the relay creates a new connection, it hides the host:port on outbound
connections, and so the server would see an ephemeral host:port and this
would cause the test to fail:
https://travis-ci.org/uber/tchannel-go/jobs/204481657

Updated the test to use a separate channel for making calls instead of
a single channel calling itself. Also disable relays to avoid races.

Pull Request Pull Request #585: Release version 1.4.0

Run Details

139 of 139 new or added lines in 6 files covered. (100.0%)

4296 of 4879 relevant lines covered (88.05%)

11880.16 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.27

/inbound.go

Build SHA Not Found

The commit SHA "c06e94329502381bda895b8c1b524dface10f6f4" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

uber / tchannel-go / 3082

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous