reactjs / react-modal / 124

pending completion

Build # 124

Build Type

Pull #253

travis-ci

Committed by

web-flow

Commit Message

[fixed] respect closeTimeoutMS during unmount

Fixes issue #17: "When the modal is unmounted, it will abruptly close,
not waiting for any animations to finish."

The bug was caused by the Modal component unmounting the portal
immediately in `componentWillUnmount` regardless of whether the portal
is currently closing or would animate to close.

Now when a Modal has a non-zero `closeTimeoutMS`, the Modal inspects the
portal state before closing.  If the portal is open or closing, but not
closed, it waits to unmount the portal.  If the portal is open and not
already closing, the Modal calls closeWithTimeout() to trigger the
close.

Adds test to ensure portal DOM persists after Modal is unmounted when
the Modal has a `closeTimeoutMS` set.  Updates existing tests to
properly unmount test Modal instances.

Pull Request Pull Request #253: [fixed] respect closeTimeoutMS during unmount

Run Details

11 of 11 new or added lines in 2 files covered. (100.0%)

230 of 285 relevant lines covered (80.7%)

16.96 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

67.39

/lib/helpers/focusManager.js

Build SHA Not Found

The commit SHA "2e975fd1f4c73f360c7a21ffcc7202ff91909faf" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

reactjs / react-modal / 124

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous