andrew-d / interfaces-rs / 388

pending completion

Build # 388

Build Type

Pull #1

travis-ci

Committed by

web-flow

Commit Message

Swap bytes when building IPv6 addresses.

As an example, the IPv6 address fe80::1 is represented in memory (in a
sin6_addr.s6_addr) as:

[0xfe, 0x80, 0x00, ..., 0x01]

So to construct an IPv6 address from 16-bit values, as is required by
net::Ipv6Addr::new, these should be passed as 0xfe80, 0x0000, etc.
However, the make_int16() function here was building them as 0x80fe,
etc. (or rather, it was being *called* in such a way to construct such
swapped integers). Because this function is used only to build IPv6
addresses, simply swapping the order of its parameters is sufficient to
properly construct IPv6 addresses.

Pull Request Pull Request #1: Swap bytes when building IPv6 addresses.

Run Details

360 of 414 relevant lines covered (86.96%)

0.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.4

src/Users/travis/build/andrew-d/interfaces-rs/src/lib.rs

Build SHA Not Found

The commit SHA "248a3d28b38179dbef3b23c382dff9d4f04bfd0f" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

andrew-d / interfaces-rs / 388

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous