decentraland / social-service-ea / 24449911581 / 1

90%

main: 90%

Pull #407

github

fix: prevent OOM crashes from subscriber leak and duplicate subscriptions

Three critical fixes for the heap exhaustion crash (510 MB after ~62h):

1. Fix cleanup bug in ws-handler: the three cleanup steps (transport.close,
   detachUser, emitter.clear) were in a single try/catch. If transport.close()
   threw (uWS throws on closed sockets), detachUser and emitter.clear were
   skipped, permanently leaking the subscriber's emitter and generators.
   Each step is now an independent function with its own error handling.

2. Guard against duplicate subscriptions: clients can call the same stream
   RPC multiple times on one connection. Each call created another async
   generator with a 1000-item value queue, doubling memory per connection.
   Crash logs confirmed this for communityMemberConnectivityUpdate.
   Added per-(address, event) deduplication in handleSubscriptionUpdates.

3. Set explicit V8 heap limit (768 MB for 1024 MB prod containers) via
   NODE_OPTIONS env var in Dockerfile, overridable at deploy time.

2369 of 2754 branches covered (86.02%)

Branch coverage included in aggregate %.

10906 of 11818 relevant lines covered (92.28%)

35.9 hits per line