benwbrum / fromthepage / 19377900481 / 1

70%

development: 70%

push

github

Fix: URL encode special characters in image filenames (#5065)

* Initial plan

* Add URL encoding to file_to_url helper for special characters

- Updated file_to_url in ApplicationHelper to URL encode each path segment
- This fixes broken images when filenames contain # or other special chars
- Added comprehensive tests for file_to_url with various special characters
- Added tests for osd_source to verify OpenSeadragon tile sources are encoded
- Added tests for thumbnail_url to verify thumbnail paths are encoded

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Fix double-encoding issue in image_url_for_download

- Removed redundant URI encoding since file_to_url now returns encoded paths
- Added test for image_url_for_download with special characters
- Verified no double-encoding occurs for filenames with # and spaces

Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>

* Remove bad test

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: benwbrum <199961+benwbrum@users.noreply.github.com>
Co-authored-by: Ben W. Brumfield <benwbrum@gmail.com>

1979 of 3497 branches covered (56.59%)

Branch coverage included in aggregate %.

8458 of 12239 relevant lines covered (69.11%)

117.44 hits per line